Repository navigation
Commit a1c3636
committed
[chore](build) Rebaseline the util/threadpool.h reach budget for the Lance reader
### What problem does this PR solve?
Issue Number: None
Related PR: #69581
Problem Summary:
BE configure runs `build-support/check-build-hygiene.sh`. Its reverse reach
budget caps how many TUs may transitively include `util/threadpool.h` at the
baseline 988 (master 9a48f81, 2026-08-18) plus 10%, that is 1087. Master
76fb880 is at 1084, and the Lance reader adds four TUs that reach it
(`format_v2/table/lance_reader.cpp`,
`format_v2/lance/lance_runtime_filter_helper.cpp` and their unit tests), so
configure on master plus this PR fails with "util/threadpool.h now reaches
1088 TUs (baseline 988 +10% = 1087)".
The four TUs add no new edge. They need `VExprContext`, directly or through
`format_v2/table_reader.h`, and `exprs/vexpr_context.h` holds
`segment_v2::ColumnIteratorOptions` by value, so it includes
`storage/segment/column_reader.h` -> `io/cache/cached_remote_file_reader.h` ->
`io/cache/block_file_cache.h` -> `util/threadpool.h`, the path the other
format_v2 readers already take. Narrowing includes inside the Lance files
cannot remove it; the record batch converter header was already narrowed to
`format_v2/column_data.h` in this PR.
As the gate's message prescribes, this rebaselines `util/threadpool.h` to the
measured 1088 (limit 1197) and records the reason next to the entry. Cutting
the `vexpr_context.h` -> `column_reader.h` edge, by moving
`ColumnIteratorOptions` into a light header, would bring the reach down to
about 846; that is a separate build cleanup.
### Release note
None
### Check List (For Author)
- Test: No need to test: build configuration only.
`bash build-support/check-build-hygiene.sh` passes on this branch and on
master 76fb880 plus this PR.
- Behavior changed: No
- Does this need documentation: No
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>1 parent 7edd9cc commit a1c3636
1 file changed
Lines changed: 8 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
587 | 587 | | |
588 | 588 | | |
589 | 589 | | |
590 | | - | |
| 590 | + | |
| 591 | + | |
| 592 | + | |
| 593 | + | |
| 594 | + | |
| 595 | + | |
| 596 | + | |
| 597 | + | |
591 | 598 | | |
592 | 599 | | |
593 | 600 | | |
| |||
0 commit comments