Skip to content

Commit a1c3636

Browse files
committed
[chore](build) Rebaseline the util/threadpool.h reach budget for the Lance reader
### What problem does this PR solve? Issue Number: None Related PR: #69581 Problem Summary: BE configure runs `build-support/check-build-hygiene.sh`. Its reverse reach budget caps how many TUs may transitively include `util/threadpool.h` at the baseline 988 (master 9a48f81, 2026-08-18) plus 10%, that is 1087. Master 76fb880 is at 1084, and the Lance reader adds four TUs that reach it (`format_v2/table/lance_reader.cpp`, `format_v2/lance/lance_runtime_filter_helper.cpp` and their unit tests), so configure on master plus this PR fails with "util/threadpool.h now reaches 1088 TUs (baseline 988 +10% = 1087)". The four TUs add no new edge. They need `VExprContext`, directly or through `format_v2/table_reader.h`, and `exprs/vexpr_context.h` holds `segment_v2::ColumnIteratorOptions` by value, so it includes `storage/segment/column_reader.h` -> `io/cache/cached_remote_file_reader.h` -> `io/cache/block_file_cache.h` -> `util/threadpool.h`, the path the other format_v2 readers already take. Narrowing includes inside the Lance files cannot remove it; the record batch converter header was already narrowed to `format_v2/column_data.h` in this PR. As the gate's message prescribes, this rebaselines `util/threadpool.h` to the measured 1088 (limit 1197) and records the reason next to the entry. Cutting the `vexpr_context.h` -> `column_reader.h` edge, by moving `ColumnIteratorOptions` into a light header, would bring the reach down to about 846; that is a separate build cleanup. ### Release note None ### Check List (For Author) - Test: No need to test: build configuration only. `bash build-support/check-build-hygiene.sh` passes on this branch and on master 76fb880 plus this PR. - Behavior changed: No - Does this need documentation: No Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
1 parent 7edd9cc commit a1c3636

1 file changed

Lines changed: 8 additions & 1 deletion

File tree

‎build-support/check-header-deps.py‎

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -587,7 +587,14 @@
587587
"gen_cpp/Types_types.h": 1993,
588588
"gen_cpp/segment_v2.pb.h": 1234,
589589
"gen_cpp/PaloInternalService_types.h": 1133,
590-
"util/threadpool.h": 988,
590+
# Rebaselined from 988 at master 76fb880330c plus the Lance reader,
591+
# 2026-10-25 (master alone: 1084). The reader adds four TUs, two sources
592+
# and their tests, and no new edge: they reach it through
593+
# exprs/vexpr_context.h, which holds segment_v2::ColumnIteratorOptions by
594+
# value and so includes storage/segment/column_reader.h ->
595+
# io/cache/cached_remote_file_reader.h -> io/cache/block_file_cache.h.
596+
# Cutting that edge would bring this down to about 846.
597+
"util/threadpool.h": 1088,
591598
# parsed_page.h holds RleDecoder<bool> by value and constructs it in the
592599
# header, so the whole storage read stack sees the RLE machinery; a live
593600
# dependency, budgeted as-is (trimming it is a refactor, not a gate).

0 commit comments

Comments
 (0)