Repository navigation
Commit 934233d
authored
[fix](regression) Stabilize external profile and VARIANT cases (#68165)
### What problem does this PR solve?
Two external regression cases rely on assumptions that no longer hold:
- The Parquet join runtime filter case requires exactly two counter
matches, so repeated profile sections fail despite sufficient filtering.
Wait for profile completion, scope counters to the fact scan, and check
the largest merged or instance value against the original thresholds
without summing duplicates.
- The remote Doris VARIANT case implicitly casts JSON text to VARIANT
and compares against obsolete output. String casts now preserve strings.
Explicitly parse valid JSON fixtures, cast numeric predicates, and
compare all eight non-Arrow queries with the internal source table. Two
known predicate-result checks prevent empty nested-path results from
passing both sides. Keep the Arrow error assertion and remove the unused
golden file.
Only regression cases and their expected-data file change.
### Release note
None
### Check List (For Author)
- Test
- [ ] Regression test
- [ ] Unit Test
- [x] Manual test
Local Groovy checks reproduced the old assertions and validated the
changes:
- Profile parsing: normal, repeated, merged, multiple-instance,
missing-counter, unrelated-table and insufficient-filtering inputs, plus
archived profiles and normalized whitespace.
- Polling: delayed completion, transient read errors and timeouts. The
full Parquet suite DSL ran with simulated SQL/profile responses for all
four queries and three wait settings.
- VARIANT suite DSL: explicit JSON parsing, SQL NULL and
malformed-string fixtures, eight matching catalog/source query pairs,
two semantic checks, ordering and the Arrow error assertion.
- Current framework result-comparison code: matching values pass; stale
output, SQL/JSON null confusion, missing/extra/reordered rows and
changed boolean values fail.
- `git diff --check` passed. Live Doris/Hive regression was not run; CI
is requested.
- Behavior changed:
- [x] No production behavior changes.
- [ ] Yes.
- Does this need documentation?
- [x] No.
- [ ] Yes.
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label1 parent d07e97b commit 934233d
3 files changed
Lines changed: 76 additions & 150 deletions
File tree
- regression-test
- data/external_table_p0/remote_doris
- suites/external_table_p0
- hive
- remote_doris
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
| 22 | + | |
42 | 23 | | |
43 | 24 | | |
44 | | - | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
45 | 40 | | |
46 | 41 | | |
47 | 42 | | |
48 | 43 | | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
| 44 | + | |
| 45 | + | |
67 | 46 | | |
68 | 47 | | |
69 | 48 | | |
| |||
108 | 87 | | |
109 | 88 | | |
110 | 89 | | |
111 | | - | |
112 | | - | |
| 90 | + | |
| 91 | + | |
113 | 92 | | |
114 | 93 | | |
115 | 94 | | |
| |||
123 | 102 | | |
124 | 103 | | |
125 | 104 | | |
126 | | - | |
127 | | - | |
| 105 | + | |
| 106 | + | |
128 | 107 | | |
129 | 108 | | |
130 | 109 | | |
| |||
139 | 118 | | |
140 | 119 | | |
141 | 120 | | |
142 | | - | |
143 | | - | |
| 121 | + | |
| 122 | + | |
144 | 123 | | |
145 | 124 | | |
146 | 125 | | |
| |||
154 | 133 | | |
155 | 134 | | |
156 | 135 | | |
157 | | - | |
158 | | - | |
| 136 | + | |
| 137 | + | |
159 | 138 | | |
160 | 139 | | |
161 | 140 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
| 57 | + | |
57 | 58 | | |
58 | 59 | | |
59 | | - | |
| 60 | + | |
60 | 61 | | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
71 | 72 | | |
72 | 73 | | |
73 | 74 | | |
| |||
104 | 105 | | |
105 | 106 | | |
106 | 107 | | |
107 | | - | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
108 | 120 | | |
| 121 | + | |
| 122 | + | |
109 | 123 | | |
110 | 124 | | |
111 | 125 | | |
| |||
116 | 130 | | |
117 | 131 | | |
118 | 132 | | |
119 | | - | |
120 | | - | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
121 | 137 | | |
122 | 138 | | |
123 | | - | |
124 | | - | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
125 | 143 | | |
126 | 144 | | |
127 | | - | |
| 145 | + | |
128 | 146 | | |
| 147 | + | |
| 148 | + | |
129 | 149 | | |
130 | 150 | | |
131 | | - | |
| 151 | + | |
132 | 152 | | |
| 153 | + | |
| 154 | + | |
133 | 155 | | |
134 | 156 | | |
135 | | - | |
| 157 | + | |
136 | 158 | | |
| 159 | + | |
| 160 | + | |
137 | 161 | | |
138 | 162 | | |
139 | | - | |
| 163 | + | |
140 | 164 | | |
| 165 | + | |
| 166 | + | |
141 | 167 | | |
142 | 168 | | |
143 | | - | |
| 169 | + | |
144 | 170 | | |
| 171 | + | |
| 172 | + | |
145 | 173 | | |
146 | 174 | | |
147 | 175 | | |
| |||
0 commit comments