You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 822f212
Browse filesBrowse the repository at this point in the historyBrowse files
[fix](be) Ignore parameters of non-contributing aggregate states
### What problem does this PR solve?
Issue Number: N/A
Related PR: #67805
Problem Summary: Parameter checks rejected merges of aggregate states without
retained counters, elements, samples or events even though these payloads do
not contribute to the result. An empty destination could also retain parameters
that conflict with subsequent contributing states.
Skip non-contributing states before compatibility checks and adopt contributing
parameters into empty destinations across TopN, limited collect, percentile,
reservoir, sequence and Window Funnel V2 implementations. Remove the V2
initialization flag and sorted-field tag. Retain checks for states that still
contribute, including V1 fixed-mode rows, bitmap filter keys, group_concat empty
strings and EMA value/time pairs. Preserve empty percentile-array result shapes
and negative collection-limit behavior. Historical trial AggState encodings
remain outside the compatibility scope.
### Release note
Non-contributing aggregate states ignore parameter differences during merging.
Empty destinations adopt the contributing state's parameters. Nonempty states
continue to reject incompatible parameters.
### Check List (For Author)
- Test: Unit Test / Regression test / Manual test
- BE ASAN and FE builds passed.
- 72 BE ASAN tests passed across 10 suites.
- All 7 SQL regression suites passed with zero failures or skips. Generated
the 132 new outputs with the repository runner and verified them in a
normal run; merge/union and both operand orders agree.
- clang-format 16.0.6, header hygiene and git diff --check passed.
- clang-tidy reports no diagnostics on changed lines after test-helper
refactoring. The full check still reports existing core/types.h NOLINTEND
and other pre-existing diagnostics.
- Behavior changed: Yes, empty payload parameters no longer reject merges.
- Does this need documentation: Yes, updated docs/aggregate-state-parameters.md.
0 commit comments