You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 7d23148
Browse filesBrowse the repository at this point in the historyBrowse files
[fix](fe) Validate Hive HDFS HA properties during catalog DDL (#68585)
### What problem does this PR solve?
Issue Number: DORIS-29461
Related PR: None
Problem Summary: Plugin-driven Hive catalogs accepted incomplete HDFS HA
properties during CREATE and ALTER. For example, a catalog with
`dfs.nameservices=ns1` but no `dfs.ha.namenodes.ns1`, or with an empty
nameservice list, could be persisted successfully and only fail when the
first external table accessed storage. The DDL validation path now binds
Hive storage properties before persisting the catalog, and HDFS HA
validation rejects empty nameservice entries and validates the required
NameNode, RPC address, and failover provider properties. The behavior is
covered by FE unit tests and an external regression suite.
### Release note
Hive Catalog CREATE and ALTER now reject incomplete HDFS HA
configurations during DDL validation.
### Check List (For Author)
- Test: Unit Test / Regression test
- FE unit tests: `PluginDrivenExternalCatalogConcurrencyTest`,
`HdfsPropertiesTest`
- External regression:
`external_table_p0/hive/test_hive_ha_catalog_validation`
- FE build and Checkstyle passed
- Behavior changed: Yes (invalid Hive HDFS HA configurations fail during
CREATE/ALTER instead of being deferred until storage access)
- Does this need documentation: No
Copy file name to clipboardExpand all lines: fe/fe-core/src/test/java/org/apache/doris/datasource/plugin/PluginDrivenExternalCatalogConcurrencyTest.java
+30Lines changed: 30 additions & 0 deletions
Original file line number
Diff line number
Diff line change
@@ -100,6 +100,36 @@ public void testAlterRejectsInvalidHiveParquetTimezone() {
100
100
Assertions.assertTrue(exception.getMessage().contains("short timezone aliases are not supported"));
Copy file name to clipboardExpand all lines: fe/fe-filesystem/fe-filesystem-hdfs-base/src/main/java/org/apache/doris/filesystem/hdfs/properties/HdfsConfigFileLoader.java
Copy file name to clipboardExpand all lines: fe/fe-filesystem/fe-filesystem-hdfs-base/src/main/java/org/apache/doris/filesystem/hdfs/properties/HdfsPropertiesUtils.java
Copy file name to clipboardExpand all lines: fe/fe-filesystem/fe-filesystem-hdfs/src/test/java/org/apache/doris/filesystem/hdfs/properties/HdfsPropertiesTest.java
0 commit comments