Repository navigation
Commit 7ca5ef5
[fix](ranger) Refuse an opt-out or refresh interval the load cannot use before it starts, and name the cause when policies arrive but no engine is built
Review round on 15e1747: the four findings that hold up.
ranger.plugin.<type>.use.rangerGroups was read through Hadoop's getBoolean,
which takes any value it cannot read as the default: a mistyped opt-out
(flase) switched groups on in the deployment that had just decided the
opposite, and Ranger reads the same property with the opposite default. It is
now read strictly - true, false, or nothing - and anything else is refused
before the load, naming the property and the value.
userStoreRefresherPollingInterval went to Ranger's enricher unread, which
parses it inside the policy engine's construction. A value that is not a
number failed there; a non-positive one failed a step later, in
Timer.schedule, after the enricher had downloaded the store and started its
refresher thread. RangerBasePlugin.setPolicies catches both, leaves the plugin
without an engine, and LoadedRangerPlugin then refused it as "Ranger Admin
could not be reached and no cache was found" - the wrong repair - with, in the
second case, the refresher thread left behind, one per CREATE CATALOG retry,
since cleanup() reaches it only through an engine that was never built. The
interval is now validated before the load as well.
The plugin also tells "no policies" apart from "policies arrived and no engine
could be built out of them" - anything the engine's construction throws lands
there, a context enricher's init() included - by noting in setPolicies whether
a versioned payload left it without an engine, and the refusal then says so
and points at the cause RangerBasePlugin.setPolicies logged.
The regression suite wrote its access policy first and waited on it: with
four Ranger Admin calls and a 5 s policy poll, a poll between two of them
brought a generation with the access policy alone, so the row filter, mask and
deny assertions that followed could run against a generation without them.
The access policy is written last, so answering on it proves the other three
are in the same generation.
Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>1 parent 15e1747 commit 7ca5ef5
5 files changed
Lines changed: 281 additions & 26 deletions
File tree
- fe/fe-authorization/fe-authorization-plugins
- fe-authorization-plugin-ranger-common/src/main/java/org/apache/doris/catalog/authorizer/ranger
- fe-authorization-plugin-ranger-doris/src/test/java/org/apache/doris/catalog/authorizer/ranger
- regression-test/suites/ranger_p2
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
45 | 47 | | |
46 | 48 | | |
47 | 49 | | |
| |||
56 | 58 | | |
57 | 59 | | |
58 | 60 | | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
59 | 70 | | |
60 | 71 | | |
61 | 72 | | |
| |||
64 | 75 | | |
65 | 76 | | |
66 | 77 | | |
67 | | - | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
68 | 82 | | |
69 | 83 | | |
70 | 84 | | |
| 85 | + | |
71 | 86 | | |
72 | 87 | | |
73 | 88 | | |
74 | 89 | | |
75 | 90 | | |
76 | | - | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
77 | 94 | | |
78 | 95 | | |
79 | 96 | | |
| |||
116 | 133 | | |
117 | 134 | | |
118 | 135 | | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
119 | 144 | | |
120 | 145 | | |
121 | 146 | | |
122 | 147 | | |
123 | 148 | | |
| 149 | + | |
| 150 | + | |
124 | 151 | | |
125 | 152 | | |
126 | 153 | | |
127 | 154 | | |
128 | 155 | | |
| 156 | + | |
| 157 | + | |
129 | 158 | | |
130 | 159 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
66 | 66 | | |
67 | 67 | | |
68 | 68 | | |
69 | | - | |
| 69 | + | |
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
74 | | - | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
75 | 85 | | |
76 | 86 | | |
77 | | - | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
78 | 149 | | |
79 | 150 | | |
80 | 151 | | |
| |||
93 | 164 | | |
94 | 165 | | |
95 | 166 | | |
96 | | - | |
97 | | - | |
| 167 | + | |
98 | 168 | | |
99 | 169 | | |
100 | 170 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| 25 | + | |
25 | 26 | | |
26 | 27 | | |
| 28 | + | |
27 | 29 | | |
28 | 30 | | |
29 | 31 | | |
| |||
165 | 167 | | |
166 | 168 | | |
167 | 169 | | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
168 | 185 | | |
169 | 186 | | |
170 | 187 | | |
| |||
230 | 247 | | |
231 | 248 | | |
232 | 249 | | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
233 | 256 | | |
234 | 257 | | |
235 | 258 | | |
| |||
313 | 336 | | |
314 | 337 | | |
315 | 338 | | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
| 380 | + | |
| 381 | + | |
| 382 | + | |
| 383 | + | |
| 384 | + | |
| 385 | + | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
| 392 | + | |
| 393 | + | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
316 | 398 | | |
317 | 399 | | |
318 | 400 | | |
| |||
0 commit comments