Skip to content

Commit 7a0116c

Browse files
committed
[fix](regression) Isolate S3 TVF insert paths
### What problem does this PR solve? Issue Number: None Related PR: None Problem Summary: The S3 TVF insert regression case wrote all runs under a fixed regression/insert_tvf_test prefix while also using delete_existing_files=true and wildcard reads. Concurrent regression jobs could delete each other's directories or infer schema from another run's files, causing flaky mismatches or missing columns. This change gives each suite run a UUID-scoped S3 prefix and uses that same prefix for both writes and reads, so deletes and wildcard reads are isolated to the current run. ### Release note None ### Check List (For Author) - Test: Regression test attempted: ./run-regression-test.sh --run -d external_table_p0/tvf/insert -s test_insert_into_s3_tvf. It could not complete because local FE at 127.0.0.1:9030 refused the MySQL connection before the first SQL statement. - Behavior changed: No, test-only path isolation. - Does this need documentation: No
1 parent 6aac7eb commit 7a0116c

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

‎regression-test/suites/external_table_p0/tvf/insert/test_insert_into_s3_tvf.groovy‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@ suite("test_insert_into_s3_tvf", "p0,external") {
2828
return
2929
}
3030

31-
def s3BasePath = "${bucket}/regression/insert_tvf_test"
31+
def s3BasePrefix = "regression/insert_tvf_test/${UUID.randomUUID().toString()}"
32+
def s3BasePath = "${bucket}/${s3BasePrefix}"
3233

3334
// file_path is now a prefix; BE generates: {prefix}{query_id}_{idx}.{ext}
3435
def s3WriteProps = { String path, String format ->
@@ -45,7 +46,7 @@ suite("test_insert_into_s3_tvf", "p0,external") {
4546
// Read uses wildcard to match generated file names
4647
def s3ReadProps = { String path, String format ->
4748
return """
48-
"uri" = "https://${bucket}.${s3_endpoint}/regression/insert_tvf_test/${path}",
49+
"uri" = "https://${bucket}.${s3_endpoint}/${s3BasePrefix}/${path}",
4950
"s3.access_key" = "${ak}",
5051
"s3.secret_key" = "${sk}",
5152
"format" = "${format}",

0 commit comments

Comments
 (0)