Repository navigation
Commit 742c58b
[test](fe) Pin shared budget groups, concurrent failures and the Iceberg comment cache limit
### What problem does this PR solve?
Issue Number: None
Related PR: #66717, #67726
Problem Summary: Three of the ported metadata cache budget tests could pass while the behavior
they guard is broken:
- `concurrentReservationsNeverExceedTheGlobalLimit` dropped the futures of its 200 submitted
reservations. If half of them threw instead of returning an empty Optional, the reservation
count and the global weight would still match. The test now calls `get()` on every future
before checking the totals.
- The bucket lifecycle test gives every physical cache its own budget group, so it cannot see a
group bucket removed while another cache of the same group is still live. Iceberg's MVCC and
list partition views share the `partition_view` group; if closing one of them dropped the
bucket, a re-created cache would start from an empty bucket and admit weight on top of what
its sibling still holds. `sharedEntryGroupKeepsItsLimitUntilItsLastPhysicalCacheCloses` keeps
60 bytes reserved in one sibling, closes and re-creates the other, and checks that it can take
only the remaining 40 and that the bucket goes away with the last sibling.
- The Iceberg catalog-limit check built only plain catalogs, which never create the
`iceberg-comment` cache. A REST vended-credentials catalog does, through the same governed
owner; the test now builds one and checks that the comment cache gets the catalog limit.
### Release note
None
### Check List (For Author)
- Test: Unit Test
- `MetaCacheBudgetManagerTest` (13) and `IcebergConnectorCacheTest` (31) pass locally.
Removing the live-sibling check from `MetaCacheBudgetManager#close` turns the new shared
group test red, and building the comment cache outside the catalog's governed owner turns
the catalog-limit test red.
- Behavior changed: No
- Does this need documentation: No
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>1 parent 5d76b69 commit 742c58b
2 files changed
Lines changed: 43 additions & 2 deletions
File tree
- fe/fe-connector
- fe-connector-cache/src/test/java/org/apache/doris/connector/cache
- fe-connector-iceberg/src/test/java/org/apache/doris/connector/iceberg
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
| 37 | + | |
37 | 38 | | |
38 | 39 | | |
39 | 40 | | |
| |||
81 | 82 | | |
82 | 83 | | |
83 | 84 | | |
| 85 | + | |
84 | 86 | | |
85 | 87 | | |
86 | | - | |
| 88 | + | |
87 | 89 | | |
88 | 90 | | |
89 | | - | |
| 91 | + | |
90 | 92 | | |
91 | 93 | | |
92 | 94 | | |
93 | 95 | | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
94 | 100 | | |
95 | 101 | | |
96 | 102 | | |
| |||
404 | 410 | | |
405 | 411 | | |
406 | 412 | | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
| 421 | + | |
| 422 | + | |
| 423 | + | |
| 424 | + | |
| 425 | + | |
| 426 | + | |
| 427 | + | |
| 428 | + | |
| 429 | + | |
| 430 | + | |
| 431 | + | |
| 432 | + | |
| 433 | + | |
| 434 | + | |
| 435 | + | |
| 436 | + | |
| 437 | + | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
407 | 441 | | |
408 | 442 | | |
409 | 443 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
250 | 250 | | |
251 | 251 | | |
252 | 252 | | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
253 | 260 | | |
254 | 261 | | |
255 | 262 | | |
| |||
0 commit comments