You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 6e94309
Browse filesBrowse the repository at this point in the historyBrowse files
[fix](be) Release deletion vector rows on read errors
### What problem does this PR solve?
Issue Number: None
Related PR: #65351
Problem Summary: Deletion vector and position-delete cache builders allocated rows/maps with raw `new` and returned `nullptr` on read or parse failures. Those error paths leaked partially built cache values because `KVCache::get` only takes ownership when the builder returns a non-null pointer. Use RAII while building `DeleteRows` and `DeleteFile`, and release ownership only after successful construction. Add fault-injection/regression coverage for V1 Iceberg deletion-vector and position-delete failures, V1 Paimon Parquet/ORC deletion-vector failures, the shared Iceberg helper, and the format v2 TableReader path.
### Release note
None
### Check List (For Author)
- Test: Regression test / Unit Test
- Added BE unit tests for V1/shared Iceberg deletion vector helper fault and stress paths.
- Added BE unit tests for V1 Iceberg reader deletion vector and position-delete read failure cache-builder paths.
- Added BE unit tests for V1 Paimon Parquet/ORC reader deletion vector read failure cache-builder paths.
- Added BE unit tests for format v2 Iceberg deletion vector fault paths.
- Extended Iceberg deletion vector regression to cover both scanner v1 and scanner v2 debug point fault injection.
- Ran build-support/clang-format.sh locally.
- Ran PATH=/usr/local/opt/llvm@16/bin:$PATH build-support/check-format.sh locally.
- Ran git diff --check locally.
- On [email protected] in /mnt/disk3/gabriel/Workspace/dev1/doris_pr65351_ut, ran ./run-be-ut.sh --run --filter="IcebergReaderTest.v1_position_delete_read_error_releases_cache_entry:IcebergReaderTest.v1_deletion_vector_read_error_releases_cache_entry:PaimonDeletionVectorTest.V1*:IcebergDeleteFileReaderHelperTest.*:IcebergV2ReaderTest.IcebergDeletionVector*:IcebergV2ReaderTest.IcebergTableReader*DeletionVector*"; 25 tests passed.
- Attempted build-support/run-clang-tidy.sh --build-dir be/cmake-build-debug-dev-perf locally with CLANG_TIDY_BINARY=/usr/local/opt/llvm@16/bin/clang-tidy; blocked by the local macOS bash 3.2 missing mapfile.
- Behavior changed: No
- Does this need documentation: No
0 commit comments