@@ -1226,6 +1226,47 @@ TEST(LanceTableReaderVectorSearchTest, MultiVectorRejectsActualNullAndNonFiniteE
12261226 }
12271227}
12281228
1229+ TEST (LanceTableReaderVectorSearchTest, RejectsInvalidQueryParallelismBeforeOpeningDataset) {
1230+ TQueryGlobals globals;
1231+ RuntimeState state (globals);
1232+ RuntimeProfile profile (" lance_invalid_query_parallelism" );
1233+ auto params = make_float32_vector_search_params ({0 .0F , 0 .0F , 0 .0F }, 2 , 0 );
1234+ params.lance_scan_params .external_search_request .vector_search_options .__set_query_parallelism (
1235+ -2 );
1236+ const Columns columns {projected_column (" _distance" , TYPE_FLOAT , true )};
1237+ LanceTableReader reader;
1238+ const auto status = init_reader (&reader, columns, &state, &profile, ¶ms);
1239+ EXPECT_FALSE (status.ok ());
1240+ EXPECT_NE (std::string::npos, status.to_string ().find (" query_parallelism" ));
1241+ }
1242+
1243+ TEST (LanceTableReaderVectorSearchTest, QueryParallelismPreservesResults) {
1244+ const std::filesystem::path uri = " ./be/test/format_v2/table/lance/data/all_types.lance" ;
1245+ LanceFixtureInfo fixture;
1246+ ASSERT_TRUE (get_fixture_info (uri, &fixture).ok ());
1247+ const Columns columns {projected_column (" row_id" , TYPE_BIGINT , false ),
1248+ projected_column (" _distance" , TYPE_FLOAT , true )};
1249+ TQueryGlobals globals;
1250+ RuntimeState state (globals);
1251+ for (const int parallelism : {-1 , 0 , 1 , 4 }) {
1252+ SCOPED_TRACE (parallelism);
1253+ auto params = make_float32_vector_search_params ({0 .0F , 0 .0F , 0 .0F }, 2 , 1 );
1254+ params.lance_scan_params .external_search_request .vector_search_options
1255+ .__set_query_parallelism (parallelism);
1256+ RuntimeProfile profile (" lance_query_parallelism" );
1257+ LanceTableReader reader;
1258+ ASSERT_TRUE (init_reader (&reader, columns, &state, &profile, ¶ms).ok ());
1259+ ASSERT_TRUE (prepare_fixture (&reader, uri, fixture, fixture.fragment_ids ).ok ());
1260+ Block block;
1261+ add_output_columns (&block, columns);
1262+ const auto rows = read_vector_search_rows (&reader, &block);
1263+ ASSERT_EQ (2U , rows.size ());
1264+ EXPECT_EQ (2 , rows[0 ].first );
1265+ EXPECT_EQ (4 , rows[1 ].first );
1266+ ASSERT_TRUE (reader.close ().ok ());
1267+ }
1268+ }
1269+
12291270TEST (LanceTableReaderVectorSearchTest, SearchesWholeSnapshotWithOffsetAndDistance) {
12301271 const std::filesystem::path dataset_uri =
12311272 " ./be/test/format_v2/table/lance/data/all_types.lance" ;
@@ -1431,6 +1472,25 @@ TEST(LanceTableReaderVectorSearchTest, ReturnsStableGlobalRowIdsAndFetchesPayloa
14311472 EXPECT_EQ (" extra" , label_values.get_data_at (0 ).to_string ());
14321473 EXPECT_EQ (" unit-x" , label_values.get_data_at (1 ).to_string ());
14331474 EXPECT_EQ (" extra" , label_values.get_data_at (2 ).to_string ());
1475+ ASSERT_NE (nullptr , fetch_profile.get_counter (" LanceRowIdFetchRows" ));
1476+ EXPECT_EQ (3 , fetch_profile.get_counter (" LanceRowIdFetchRows" )->value ());
1477+ ASSERT_NE (nullptr , fetch_profile.get_counter (" LanceRowIdFetchCalls" ));
1478+ EXPECT_EQ (1 , fetch_profile.get_counter (" LanceRowIdFetchCalls" )->value ());
1479+ Block second_block;
1480+ add_output_columns (&second_block, payload_columns);
1481+ ASSERT_TRUE (payload_reader
1482+ .read_by_row_ids (make_lance_range (dataset_uri, fixture.version ,
1483+ fixture.fragment_ids ),
1484+ fetch_row_ids, &second_block)
1485+ .ok ());
1486+ EXPECT_EQ (6 , fetch_profile.get_counter (" LanceRowIdFetchRows" )->value ());
1487+ EXPECT_EQ (2 , fetch_profile.get_counter (" LanceRowIdFetchCalls" )->value ());
1488+ ASSERT_TRUE (payload_reader
1489+ .read_by_row_ids (make_lance_range (dataset_uri, fixture.version ,
1490+ fixture.fragment_ids ),
1491+ {}, &second_block)
1492+ .ok ());
1493+ EXPECT_EQ (2 , fetch_profile.get_counter (" LanceRowIdFetchCalls" )->value ());
14341494 EXPECT_TRUE (payload_reader.close ().ok ());
14351495}
14361496
0 commit comments