Skip to content

Commit 58fae14

Browse files
csun5285claude
andcommitted
[test](changelog) Run existing changelog, stream, time travel and IVM suites with a VARIANT column
### What problem does this PR solve? Issue Number: None Related PR: None Problem Summary: Only changelog_p0/test_changelog_variant covered VARIANT columns in changelog. 22 existing suites now also give their changelog tables a `jv VARIANT` column, written on every full-row INSERT as parse_to_variant('{"k": <first value>, "d": {"row": "<row values>"}}'), so an update changes it, and read with jv['d']['row'] next to the columns they already check: - changelog_p0: basic (partial update not touching jv, DELETE, sequence column), partial update of keys only, MOW light delete, compaction, multi segment (jv from a stream load column mapping), auto partition, TTL, CHANGES syntax, append-only projection, cloud compaction - table_stream_p0: MIN_DELTA stream, MIN_DELTA delete-before, snapshot and reset streams (sinks carry jv and every row's jv['k'] must equal its id) - time_travel_p0: MOW and DUP time travel, including the old jv of a snapshot and after compaction - mtmv_p0/ivm: basic (jv flows into SELECT * materialized views through incremental refresh), aggregation, inner join, DUP keys and MTMV changelog - cloud_p0/table_stream: end to end The other columns of every existing result are unchanged; only jv columns are appended. Two assertions count the visible columns or compare SELECT t.* and now account for jv. changelog_p0/test_changelog_flexible_partial_update is left alone: flexible partial update rejects tables with a VARIANT column. ### Release note None ### Check List (For Author) - Test: Regression test - all 22 suites pass on a local coupled cluster, and the two cloud suites on a local cloud cluster; .out files regenerated with -forceGenOut and checked: no existing column changed - Behavior changed: No - Does this need documentation: No Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent 9a2db12 commit 58fae14

34 files changed

Lines changed: 1074 additions & 807 deletions
Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
-- This file is automatically generated. You should know what you did if you want to edit this
22
-- !auto_partition_data --
3-
2026-08-10 1 first
4-
2026-08-11 2 second
3+
2026-08-10 1 first {"d":{"row":"2026-08-10 1 first"},"k":"2026-08-10"} 2026-08-10 1 first
4+
2026-08-11 2 second {"d":{"row":"2026-08-11 2 second"},"k":"2026-08-11"} 2026-08-11 2 second
55

66
-- !auto_partition_changelog --
7-
0 2026-08-10 1 first
8-
0 2026-08-11 2 second
7+
0 2026-08-10 1 first {"d":{"row":"2026-08-10 1 first"},"k":"2026-08-10"} 2026-08-10 1 first
8+
0 2026-08-11 2 second {"d":{"row":"2026-08-11 2 second"},"k":"2026-08-11"} 2026-08-11 2 second
99

‎regression-test/data/changelog_p0/test_changelog_basic.out‎

Lines changed: 34 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -6,38 +6,38 @@
66
0 1 1 10 10
77

88
-- !dup_raw --
9-
1 1 1 10 10
10-
1 1 1 11 11
11-
2 2 2 20 20
12-
3 3 3 30 30
9+
1 1 1 10 10 {"d":{"row":"1 1 1 10 10"},"k":1} 1 1 1 10 10
10+
1 1 1 11 11 {"d":{"row":"1 1 1 11 11"},"k":1} 1 1 1 11 11
11+
2 2 2 20 20 {"d":{"row":"2 2 2 20 20"},"k":2} 2 2 2 20 20
12+
3 3 3 30 30 {"d":{"row":"3 3 3 30 30"},"k":3} 3 3 3 30 30
1313

1414
-- !dup_changelog --
15-
0 1 1 1 10 10
16-
0 2 2 2 20 20
17-
0 1 1 1 11 11
18-
0 3 3 3 30 30
15+
0 1 1 1 10 10 {"d":{"row":"1 1 1 10 10"},"k":1} 1 1 1 10 10
16+
0 2 2 2 20 20 {"d":{"row":"2 2 2 20 20"},"k":2} 2 2 2 20 20
17+
0 1 1 1 11 11 {"d":{"row":"1 1 1 11 11"},"k":1} 1 1 1 11 11
18+
0 3 3 3 30 30 {"d":{"row":"3 3 3 30 30"},"k":3} 3 3 3 30 30
1919

2020
-- !mow_raw --
21-
2 2 2 2000 201
21+
2 2 2 2000 201 {"d":{"row":"2 2 2 20 20"},"k":2} 2 2 2 20 20
2222

2323
-- !mow_changelog --
24-
0 1 1 1 10 10
25-
0 2 2 2 20 20
26-
1 2 2 2 20 200
27-
1 2 2 2 2000 200
28-
1 2 2 2 2000 201
29-
2 1 1 1 \N \N
24+
0 1 1 1 10 10 {"d":{"row":"1 1 1 10 10"},"k":1} 1 1 1 10 10
25+
0 2 2 2 20 20 {"d":{"row":"2 2 2 20 20"},"k":2} 2 2 2 20 20
26+
1 2 2 2 20 200 {"d":{"row":"2 2 2 20 20"},"k":2} 2 2 2 20 20
27+
1 2 2 2 2000 200 {"d":{"row":"2 2 2 20 20"},"k":2} 2 2 2 20 20
28+
1 2 2 2 2000 201 {"d":{"row":"2 2 2 20 20"},"k":2} 2 2 2 20 20
29+
2 1 1 1 \N \N \N \N
3030

3131
-- !mow_before_raw --
32-
2 2 2 2000 201
32+
2 2 2 2000 201 {"d":{"row":"2 2 2 20 20"},"k":2} 2 2 2 20 20
3333

3434
-- !mow_before_changelog --
35-
0 1 1 1 10 10 \N \N
36-
0 2 2 2 20 20 \N \N
37-
1 2 2 2 20 200 20 20
38-
1 2 2 2 2000 200 20 200
39-
1 2 2 2 2000 201 2000 200
40-
2 1 1 1 10 10 10 10
35+
0 1 1 1 10 10 \N \N {"d":{"row":"1 1 1 10 10"},"k":1} \N 1 1 1 10 10 \N
36+
0 2 2 2 20 20 \N \N {"d":{"row":"2 2 2 20 20"},"k":2} \N 2 2 2 20 20 \N
37+
1 2 2 2 20 200 20 20 {"d":{"row":"2 2 2 20 20"},"k":2} {"d":{"row":"2 2 2 20 20"},"k":2} 2 2 2 20 20 2 2 2 20 20
38+
1 2 2 2 2000 200 20 200 {"d":{"row":"2 2 2 20 20"},"k":2} {"d":{"row":"2 2 2 20 20"},"k":2} 2 2 2 20 20 2 2 2 20 20
39+
1 2 2 2 2000 201 2000 200 {"d":{"row":"2 2 2 20 20"},"k":2} {"d":{"row":"2 2 2 20 20"},"k":2} 2 2 2 20 20 2 2 2 20 20
40+
2 1 1 1 10 10 10 10 {"d":{"row":"1 1 1 10 10"},"k":1} {"d":{"row":"1 1 1 10 10"},"k":1} 1 1 1 10 10 1 1 1 10 10
4141

4242
-- !mow_reinsert_before_changelog --
4343
0 1 10 \N
@@ -52,18 +52,18 @@
5252
-- !mow_seq_raw --
5353

5454
-- !mow_seq_changelog --
55-
0 1 1 1 100 100 \N \N
56-
1 1 1 1 300 300 100 100
57-
1 1 1 1 300 350 300 300
58-
1 1 1 1 400 350 300 350
59-
2 1 1 1 400 350 400 350
55+
0 1 1 1 100 100 \N \N {"d":{"row":"1 1 1 100 100 2"},"k":1} \N 1 1 1 100 100 2 \N
56+
1 1 1 1 300 300 100 100 {"d":{"row":"1 1 1 300 300 3"},"k":1} {"d":{"row":"1 1 1 100 100 2"},"k":1} 1 1 1 300 300 3 1 1 1 100 100 2
57+
1 1 1 1 300 350 300 300 {"d":{"row":"1 1 1 300 300 3"},"k":1} {"d":{"row":"1 1 1 300 300 3"},"k":1} 1 1 1 300 300 3 1 1 1 300 300 3
58+
1 1 1 1 400 350 300 350 {"d":{"row":"1 1 1 300 300 3"},"k":1} {"d":{"row":"1 1 1 300 300 3"},"k":1} 1 1 1 300 300 3 1 1 1 300 300 3
59+
2 1 1 1 400 350 400 350 {"d":{"row":"1 1 1 300 300 3"},"k":1} {"d":{"row":"1 1 1 300 300 3"},"k":1} 1 1 1 300 300 3 1 1 1 300 300 3
6060

6161
-- !mow_seq_changelog_skip_delete_bitmap --
62-
0 1 1 1 100 100 \N \N
63-
1 1 1 1 200 200 100 100
64-
1 1 1 1 300 300 100 100
65-
1 1 1 1 300 350 300 300
66-
1 1 1 1 400 350 300 350
67-
1 1 1 1 400 360 400 350
68-
2 1 1 1 400 350 400 350
62+
0 1 1 1 100 100 \N \N {"d":{"row":"1 1 1 100 100 2"},"k":1} \N 1 1 1 100 100 2 \N
63+
1 1 1 1 200 200 100 100 {"d":{"row":"1 1 1 200 200 1"},"k":1} {"d":{"row":"1 1 1 100 100 2"},"k":1} 1 1 1 200 200 1 1 1 1 100 100 2
64+
1 1 1 1 300 300 100 100 {"d":{"row":"1 1 1 300 300 3"},"k":1} {"d":{"row":"1 1 1 100 100 2"},"k":1} 1 1 1 300 300 3 1 1 1 100 100 2
65+
1 1 1 1 300 350 300 300 {"d":{"row":"1 1 1 300 300 3"},"k":1} {"d":{"row":"1 1 1 300 300 3"},"k":1} 1 1 1 300 300 3 1 1 1 300 300 3
66+
1 1 1 1 400 350 300 350 {"d":{"row":"1 1 1 300 300 3"},"k":1} {"d":{"row":"1 1 1 300 300 3"},"k":1} 1 1 1 300 300 3 1 1 1 300 300 3
67+
1 1 1 1 400 360 400 350 {"d":{"row":"1 1 1 300 300 3"},"k":1} {"d":{"row":"1 1 1 300 300 3"},"k":1} 1 1 1 300 300 3 1 1 1 300 300 3
68+
2 1 1 1 400 350 400 350 {"d":{"row":"1 1 1 300 300 3"},"k":1} {"d":{"row":"1 1 1 300 300 3"},"k":1} 1 1 1 300 300 3 1 1 1 300 300 3
6969

0 commit comments

Comments
 (0)