Skip to content

Commit 532a7ea

Browse files
morningmanclaude
andcommitted
[feature](arrow-flight) Log a failed session action at WARN, not ERROR
A session action that fails answers the client with the failure; the frontend carries on. ERROR is for what it cannot recover from. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01Ja986K4PEm2LD8u44L9jd2
1 parent 8e0fa7e commit 532a7ea

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

‎fe/fe-core/src/main/java/org/apache/doris/arrowflight/DorisFlightSqlProducer.java‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -659,11 +659,11 @@ public void setSessionOptions(final SetSessionOptionsRequest request, final Call
659659
listener.onCompleted();
660660
} catch (FlightRuntimeException e) {
661661
// Same as in getFlightInfoStatement: keep the status the session's command lock chose.
662-
LOG.error("set session options failed", e);
662+
LOG.warn("set session options failed", e);
663663
listener.onError(e);
664664
} catch (Throwable e) {
665665
String errMsg = "set session options failed, " + e.getMessage();
666-
LOG.error(errMsg, e);
666+
LOG.warn(errMsg, e);
667667
listener.onError(CallStatus.INTERNAL.withDescription(errMsg).withCause(e).toRuntimeException());
668668
}
669669
}
@@ -679,11 +679,11 @@ public void getSessionOptions(final GetSessionOptionsRequest request, final Call
679679
listener.onNext(new GetSessionOptionsResult(options));
680680
listener.onCompleted();
681681
} catch (FlightRuntimeException e) {
682-
LOG.error("get session options failed", e);
682+
LOG.warn("get session options failed", e);
683683
listener.onError(e);
684684
} catch (Throwable e) {
685685
String errMsg = "get session options failed, " + e.getMessage();
686-
LOG.error(errMsg, e);
686+
LOG.warn(errMsg, e);
687687
listener.onError(CallStatus.INTERNAL.withDescription(errMsg).withCause(e).toRuntimeException());
688688
}
689689
}
@@ -700,7 +700,7 @@ public void closeSession(CloseSessionRequest request, final CallContext context,
700700
try {
701701
flightSessionsManager.closeConnectContext(context.peerIdentity());
702702
} catch (final Throwable e) {
703-
LOG.error("closeSession failed", e);
703+
LOG.warn("closeSession failed", e);
704704
listener.onError(
705705
CallStatus.INTERNAL.withDescription("closeSession failed").withCause(e).toRuntimeException());
706706
return;

0 commit comments

Comments
 (0)