You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 5108dd2
Browse filesBrowse the repository at this point in the historyBrowse files
[fix](regression) Scope condition cache assertions to query profiles
### What problem does this PR solve?
Issue Number: None
Related PR: #68672
Problem Summary:
The eligibility regression compares BE-wide condition-cache lookup counters.
Concurrent suites and internal statistics queries can increment these counters,
and fuzzy session initialization can override its global-disable attempt.
The assertion can therefore fail even when the tested scan bypasses the cache.
Count actual segment lookup attempts, including misses, in OLAP reader
statistics and expose ConditionCacheLookup in the scan profile. Identify each
regression execution with a unique SQL comment, wait for its completed profile,
and require every lookup counter to be zero. Preserve result comparisons and
positive deterministic lookup/hit coverage. Remove global metric sampling,
global session changes and the nonConcurrent restriction.
### Release note
Expose ConditionCacheLookup in OLAP scan profiles.
### Check List (For Author)
- Test: Regression test / Unit Test / Manual test
- ASAN BE build passed using build.sh --be -j 48 with ENABLE_PCH=OFF.
- All 37 targeted SegmentIteratorCandidatePushdownTest and VirtualSlotRefTest tests passed using run-be-ut.sh.
- condition_cache_eligibility passed with fuzzy session initialization and concurrent cache-eligible queries. The BE-wide metric increased from 36 to 2952 while all 45 ineligible query profiles reported zero lookups; deterministic lookup/hit checks passed.
- clang-format/check-format 16.0.6, header hygiene, Groovy compilation, git diff checks and clang-tidy changed-line checks passed.
- Behavior changed: Yes. OLAP profiles expose lookup attempts and the regression uses query-scoped counters. Cache eligibility and query results are unchanged.
- Does this need documentation: No
0 commit comments