Skip to content

Commit 4bc8897

Browse files
authored
[fix](function) The constant parameter of json_parse_error_to_value caused a crash (#55816)
### What problem does this PR solve? ```text /root/doris/be/src/vec/exprs/vexpr_context.cpp:61:5: runtime error: member call on null pointer of type 'doris::vectorized::IColumn' *** Query id: 4de27b4f69f442db-b95f0945ca48a16e *** *** is nereids: 1 *** *** tablet id: 0 *** *** Aborted at 1757407871 (unix time) try "date -d @1757407871" if you are using GNU date *** *** Current BE git commitID: ecf3edb680 *** *** SIGSEGV address not mapped to object (@0x0) received by PID 223317 (TID 226216 OR 0x7b53e70b3700) from PID 0; stack trace: *** 0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at /root/doris/be/src/common/signal_handler.h:420 1# 0x00007F5C38CFED10 in /lib64/libpthread.so.0 2# doris::vectorized::VExprContext::execute(doris::vectorized::Block*, int*) at /root/doris/be/src/vec/exprs/vexpr_context.cpp:61 3# doris::vectorized::Scanner::_do_projections(doris::vectorized::Block*, doris::vectorized::Block*) at /root/doris/be/src/vec/exec/scan/scanner.cpp:191 4# doris::vectorized::Scanner::get_block_after_projects(doris::RuntimeState*, doris::vectorized::Block*, bool*) at /root/doris/be/src/vec/exec/scan/scanner.cpp:83 5# doris::vectorized::ScannerScheduler::_scanner_scan(std::shared_ptr<doris::vectorized::ScannerContext>, std::shared_ptr<doris::vectorized::ScanTask>) at /root/doris/be/src/vec/exec/scan/scanner_scheduler.cpp:182 6# doris::vectorized::ScannerScheduler::submit(std::shared_ptr<doris::vectorized::ScannerContext>, std::shared_ptr<doris::vectorized::ScanTask>)::$_0::operator()() const::{lambda()#1}::operator()() const::{lambda()#1}::operator()() const at /root/doris/be/src/vec/exec/scan/scanner_scheduler.cpp:96 7# doris::vectorized::ScannerScheduler::submit(std::shared_ptr<doris::vectorized::ScannerContext>, std::shared_ptr<doris::vectorized::ScanTask>)::$_0::operator()() const::{lambda()#1}::operator()() const at /root/doris/be/src/vec/exec/scan/scanner_scheduler.cpp:95 8# bool std::__invoke_impl<bool, doris::vectorized::ScannerScheduler::submit(std::shared_ptr<doris::vectorized::ScannerContext>, std::shared_ptr<doris::vectorized::ScanTask>)::$_0::operator()() const::{lambda()#1}&>(std::__invoke_other, doris::vectorized::ScannerScheduler::submit(std::shared_ptr<doris::vectorized::ScannerContext>, std::shared_ptr<doris::vectorized::ScanTask>)::$_0::operator()() const::{lambda()#1}&) at /root/ldb_toolchain_taipan/bin/../lib/gcc/x86_64-pc-linux-gnu/15/include/g++-v15/bits/invoke.h:63 9# std::enable_if<is_invocable_r_v<bool, doris::vectorized::ScannerScheduler::submit(std::shared_ptr<doris::vectorized::ScannerContext>, std::shared_ptr<doris::vectorized::ScanTask>)::$_0::operator()() const::{lambda()#1}&>, bool>::type std::__invoke_r<bool, doris::vectorized::ScannerScheduler::submit(std::shared_ptr<doris::vectorized::ScannerContext>, std::shared_ptr<doris::vectorized::ScanTask>)::$_0::operator()() const::{lambda()#1}&>(doris::vectorized::ScannerScheduler::submit(std::shared_ptr<doris::vectorized::ScannerContext>, std::shared_ptr<doris::vectorized::ScanTask>)::$_0::operator()() const::{lambda()#1}&) at /root/ldb_toolchain_taipan/bin/../lib/gcc/x86_64-pc-linux-gnu/15/include/g++-v15/bits/invoke.h:116 10# std::_Function_handler<bool (), doris::vectorized::ScannerScheduler::submit(std::shared_ptr<doris::vectorized::ScannerContext>, std::shared_ptr<doris::vectorized::ScanTask>)::$_0::operator()() const::{lambda()#1}>::_M_invoke(std::_Any_data const&) at /root/ldb_toolchain_taipan/bin/../lib/gcc/x86_64-pc-linux-gnu/15/include/g++-v15/bits/std_function.h:292 11# std::function<bool ()>::operator()() const at /root/ldb_toolchain_taipan/bin/../lib/gcc/x86_64-pc-linux-gnu/15/include/g++-v15/bits/std_function.h:593 12# doris::vectorized::ScannerSplitRunner::process_for(std::chrono::duration<long, std::ratio<1l, 1000000000l> >) at /root/doris/be/src/vec/exec/scan/scanner_scheduler.cpp:410 13# doris::vectorized::PrioritizedSplitRunner::process() at /root/doris/be/src/vec/exec/executor/time_sharing/prioritized_split_runner.cpp:103 14# doris::vectorized::TimeSharingTaskExecutor::_dispatch_thread() at /root/doris/be/src/vec/exec/executor/time_sharing/time_sharing_task_executor.cpp:570 15# void std::__invoke_impl<void, void (doris::vectorized::TimeSharingTaskExecutor::*&)(), doris::vectorized::TimeSharingTaskExecutor*&>(std::__invoke_memfun_deref, void (doris::vectorized::TimeSharingTaskExecutor::*&)(), doris::vectorized::TimeSharingTaskExecutor*&) at /root/ldb_toolchain_taipan/bin/../lib/gcc/x86_64-pc-linux-gnu/15/include/g++-v15/bits/invoke.h:76 16# std::__invoke_result<void (doris::vectorized::TimeSharingTaskExecutor::*&)(), doris::vectorized::TimeSharingTaskExecutor*&>::type std::__invoke<void (doris::vectorized::TimeSharingTaskExecutor::*&)(), doris::vectorized::TimeSharingTaskExecutor*&>(void (doris::vectorized::TimeSharingTaskExecutor::*&)(), doris::vectorized::TimeSharingTaskExecutor*&) at /root/ldb_toolchain_taipan/bin/../lib/gcc/x86_64-pc-linux-gnu/15/include/g++-v15/bits/invoke.h:98 17# void std::_Bind<void (doris::vectorized::TimeSharingTaskExecutor::*(doris::vectorized::TimeSharingTaskExecutor*))()>::__call<void, , 0ul>(std::tuple<>&&, std::_Index_tuple<0ul>) at /root/ldb_toolchain_taipan/bin/../lib/gcc/x86_64-pc-linux-gnu/15/include/g++-v15/functional:515 18# void std::_Bind<void (doris::vectorized::TimeSharingTaskExecutor::*(doris::vectorized::TimeSharingTaskExecutor*))()>::operator()<, void>() at /root/ldb_toolchain_taipan/bin/../lib/gcc/x86_64-pc-linux-gnu/15/include/g++-v15/functional:600 19# void std::__invoke_impl<void, std::_Bind<void (doris::vectorized::TimeSharingTaskExecutor::*(doris::vectorized::TimeSharingTaskExecutor*))()>&>(std::__invoke_other, std::_Bind<void (doris::vectorized::TimeSharingTaskExecutor::*(doris::vectorized::TimeSharingTaskExecutor*))()>&) at /root/ldb_toolchain_taipan/bin/../lib/gcc/x86_64-pc-linux-gnu/15/include/g++-v15/bits/invoke.h:63 20# std::enable_if<is_invocable_r_v<void, std::_Bind<void (doris::vectorized::TimeSharingTaskExecutor::*(doris::vectorized::TimeSharingTaskExecutor*))()>&>, void>::type std::__invoke_r<void, std::_Bind<void (doris::vectorized::TimeSharingTaskExecutor::*(doris::vectorized::TimeSharingTaskExecutor*))()>&>(std::_Bind<void (doris::vectorized::TimeSharingTaskExecutor::*(doris::vectorized::TimeSharingTaskExecutor*))()>&) at /root/ldb_toolchain_taipan/bin/../lib/gcc/x86_64-pc-linux-gnu/15/include/g++-v15/bits/invoke.h:119 21# std::_Function_handler<void (), std::_Bind<void (doris::vectorized::TimeSharingTaskExecutor::*(doris::vectorized::TimeSharingTaskExecutor*))()> >::_M_invoke(std::_Any_data const&) at /root/ldb_toolchain_taipan/bin/../lib/gcc/x86_64-pc-linux-gnu/15/include/g++-v15/bits/std_function.h:292 22# std::function<void ()>::operator()() const at /root/ldb_toolchain_taipan/bin/../lib/gcc/x86_64-pc-linux-gnu/15/include/g++-v15/bits/std_function.h:593 23# doris::Thread::supervise_thread(void*) at /root/doris/be/src/util/thread.cpp:460 24# asan_thread_start(void*) in /root/doris/be/output/lib/doris_be 25# start_thread in /lib64/libpthread.so.0 26# __GI___clone in /lib64/libc.so.6 ``` Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
1 parent a9d5c17 commit 4bc8897

3 files changed

Lines changed: 38 additions & 13 deletions

File tree

‎be/src/vec/functions/function_jsonb.cpp‎

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -182,18 +182,16 @@ class FunctionJsonbParseBase : public IFunction {
182182
auto&& [col_from, col_from_is_const] =
183183
unpack_if_const(block.get_by_position(arguments[0]).column);
184184

185-
if (col_from_is_const) {
186-
if (col_from->is_null_at(0)) {
187-
auto col_str = ColumnString::create();
188-
col_str->insert_default();
189-
auto null_map = ColumnUInt8::create(1, 1);
190-
auto nullable_col = ColumnNullable::create(std::move(col_str), std::move(null_map));
191-
if (input_rows_count > 1) {
192-
block.get_by_position(result).column =
193-
ColumnConst::create(std::move(nullable_col), input_rows_count);
194-
} else {
195-
block.get_by_position(result).column = std::move(nullable_col);
196-
}
185+
if (col_from_is_const && col_from->is_null_at(0)) {
186+
auto col_str = ColumnString::create();
187+
col_str->insert_default();
188+
auto null_map = ColumnUInt8::create(1, 1);
189+
auto nullable_col = ColumnNullable::create(std::move(col_str), std::move(null_map));
190+
if (input_rows_count > 1) {
191+
block.get_by_position(result).column =
192+
ColumnConst::create(std::move(nullable_col), input_rows_count);
193+
} else {
194+
block.get_by_position(result).column = std::move(nullable_col);
197195
}
198196
return Status::OK();
199197
}
@@ -303,7 +301,8 @@ class FunctionJsonbParseBase : public IFunction {
303301
continue;
304302
}
305303

306-
const auto& val = col_from_string->get_data_at(i);
304+
auto index = index_check_const(i, col_from_is_const);
305+
const auto& val = col_from_string->get_data_at(index);
307306
auto st = jsonb_value.from_json_string(val.data, val.size);
308307
if (st.ok()) {
309308
// insert jsonb format data

‎regression-test/data/query_p0/sql_functions/conditional_functions/test_json_parse.out‎

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,3 +53,27 @@ null
5353
8 123
5454
9 [1,2,3]
5555

56+
-- !parse_from_table_value3 --
57+
1 {}
58+
2 {}
59+
3 {}
60+
4 {}
61+
5 {}
62+
6 {}
63+
7 {}
64+
8 {}
65+
8 {}
66+
9 {}
67+
68+
-- !parse_from_table_value4 --
69+
1 {"name":"Alice2","age":32}
70+
2 {"name":"Bob","age":25}
71+
3 {"name":"Jack","age":28}
72+
4 {"name":"Jim","age":33}
73+
5 \N
74+
6 \N
75+
7 [1,2,3]
76+
8 {"key":"value"}
77+
8 {"key2":"value2"}
78+
9 {"key":"value"}
79+

‎regression-test/suites/query_p0/sql_functions/conditional_functions/test_json_parse.groovy‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,8 @@ suite("test_json_parse") {
4545
qt_parse_from_table_null "SELECT id, json_parse_error_to_null(json_str) FROM test_json_parse_table ORDER BY id;"
4646
qt_parse_from_table_value1 "SELECT id, json_parse_error_to_value(json_str) FROM test_json_parse_table ORDER BY id;"
4747
qt_parse_from_table_value2 "SELECT id, json_parse_error_to_value(json_str, json_value) FROM test_json_parse_table ORDER BY id;"
48+
qt_parse_from_table_value3 "SELECT id, json_parse_error_to_value('{}', json_value) FROM test_json_parse_table ORDER BY id;"
49+
qt_parse_from_table_value4 "SELECT id, json_parse_error_to_value('{invalied}', json_value) FROM test_json_parse_table ORDER BY id;"
4850

4951
check_fold_consistency "json_parse_error_to_null('{\"key\": \"value\"}')"
5052
check_fold_consistency "json_parse_error_to_null('Invalid JSON')"

0 commit comments

Comments
 (0)