Repository navigation
Commit 49af192
authored
[fix](transaction) avoid aborting newer same-label transactions (#64939)
### What problem does this PR solve?
In cloud mode, `CloudMetaMgr::abort_txn` currently prefers `db_id +
label` over `txn_id` when building `AbortTxnRequest`.
For stream load rollback, the context usually contains both `txn_id` and
`label`. If an old stream load attempt is aborted externally but its
BE-side execution is still cleaning up later, its rollback may abort by
label instead of by the original txn id.
When the upstream retries with the same label, this label-based rollback
can match and abort a newer running transaction with the same label,
causing the new attempt to fail with:
```
txn is not in 1 state, txn_status=4
```
### Solution
Prefer txn_id when aborting a cloud stream load transaction. Fall back
to db_id + label only when txn_id is not available.
This makes rollback cleanup target the exact failed transaction, instead
of affecting another transaction that happens to use the same label.1 parent 9fc6513 commit 49af192
2 files changed
Lines changed: 66 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1669 | 1669 | | |
1670 | 1670 | | |
1671 | 1671 | | |
1672 | | - | |
| 1672 | + | |
| 1673 | + | |
| 1674 | + | |
1673 | 1675 | | |
1674 | 1676 | | |
1675 | | - | |
1676 | | - | |
1677 | 1677 | | |
1678 | 1678 | | |
1679 | 1679 | | |
1680 | 1680 | | |
1681 | 1681 | | |
| 1682 | + | |
1682 | 1683 | | |
1683 | 1684 | | |
1684 | 1685 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| 31 | + | |
31 | 32 | | |
32 | 33 | | |
33 | 34 | | |
| |||
43 | 44 | | |
44 | 45 | | |
45 | 46 | | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
46 | 76 | | |
47 | 77 | | |
48 | 78 | | |
| |||
170 | 200 | | |
171 | 201 | | |
172 | 202 | | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
173 | 235 | | |
174 | 236 | | |
175 | 237 | | |
| |||
0 commit comments