Repository navigation
Commit 43f9ceb
authored
[fix](join) Preserve input nullability for ASOF match conditions (#69630)
### What problem does this PR solve?
Issue Number: N/A
Related PR: #69616
Problem Summary: Outer ASOF joins can declare a NOT NULL input
expression as nullable while BE evaluates the match key before null
padding. Root cause: the final `AdjustNullable` pass uses join output
nullability for the match condition. Preserve child input nullability
for ASOF match conditions, retaining existing behavior for ordinary
joins.
### Release note
Fix incorrect nullability in ASOF JOIN match conditions.
### Check List (For Author)
- Test: Added FE unit coverage for all four ASOF join types and a
regular LEFT OUTER JOIN control; tests not run locally. Targeted
Checkstyle passed with zero violations.
- Manual diagnosis: The full CTAS reproducer fails on master with
nullable output normalization removed
(`declared=Nullable(DateTimeV2(0)), actual=DATETIMEV2`). No post-fix
build or runtime validation performed.
- Behavior changed: Yes. ASOF match conditions retain child input
nullability.
- Does this need documentation: No1 parent 94ad139 commit 43f9ceb
2 files changed
Lines changed: 73 additions & 3 deletions
File tree
- fe/fe-core/src
- main/java/org/apache/doris/nereids/rules/rewrite
- test/java/org/apache/doris/nereids/rules/rewrite
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
194 | 194 | | |
195 | 195 | | |
196 | 196 | | |
197 | | - | |
| 197 | + | |
| 198 | + | |
198 | 199 | | |
199 | | - | |
| 200 | + | |
| 201 | + | |
200 | 202 | | |
201 | 203 | | |
202 | 204 | | |
| |||
205 | 207 | | |
206 | 208 | | |
207 | 209 | | |
208 | | - | |
| 210 | + | |
209 | 211 | | |
210 | 212 | | |
211 | 213 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
0 commit comments