You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 41567d7
Browse filesBrowse the repository at this point in the historyBrowse files
committed
[fix](be) Keep ADLS names literal and canonicalize Azure hosts in validate_azure_uri
Review follow-up for #68117, three defects in the new native Azure URI
contract:
- S3URI::parse() stripped '?' and '#' from ABFS/WASB object paths. Iceberg's
ADLSLocation ("^(abfss?|wasbs?)://([^/?#]+)(.*)?$") and Hadoop's Path both
take everything after the authority as the object path, so an object
named path/a?b#c.parquet was opened as path/a. Query and fragment are now
only stripped for the S3 and HTTP(S) schemes.
- The OneLake fence compared the raw authority, so an explicit port
(onelake.dfs.fabric.microsoft.com:443) or a trailing DNS root dot made a
genuine Fabric location pass the later checks and reach the native client.
The fence now matches on the DNS host (case-folded, no port, no root dot).
- Azure RA-GRS/RA-GZRS secondary endpoints append "-secondary" to the
account label while keeping the primary account identity and keys (the SDK
signs with the credential's account name and only swaps the host). The
account check compared that label with the credential and rejected valid
secondary reads. On official Azure hosts the suffix now folds to the
primary account for the ABFS/WASB endpoint identity and for the credential
account check; HTTP(S) transport matching stays exact.
Tests: S3URITest.QueryAndFragmentAreLiteralOnlyInAdlsPaths (plus '?'/'#'
names in IcebergAdlsPathsPreserveLiteralPercentSequences),
S3ClientFactoryTest.OneLakeFenceIgnoresPortAndDnsRootDot,
AllowsDocumentedAzureSecondaryEndpoints and
SecondaryFoldingKeepsOtherAccountsApart.
Issue: #68103
Related PR: #67470
Co-authored-by: xylaaaaa <[email protected]>
Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
0 commit comments