Skip to content

Commit 38eb879

Browse files
committed
[test](be) Fix parquet empty selection profile test
### What problem does this PR solve? Issue Number: None Related PR: None Problem Summary: The empty selection profile counter unit test used a simple id > 10 predicate on test data containing ids 1 through 5. That predicate supports zonemap evaluation, so the row group can be pruned before any batch is read and the expected batch-level profile counters remain zero. Use an equivalent always-false row-level expression that is not eligible for zonemap pruning, allowing the test to exercise the intended empty selection batch counter path. ### Release note None ### Check List (For Author) - Test: Unit Test - git diff --check -- be/test/format_v2/parquet/parquet_reader_test.cpp - Attempted ./run-be-ut.sh --run --filter='NewParquetReaderTest.EmptySelectionUpdatesProfileCounters', but the local environment failed during BE UT build setup because thirdparty/installed/bin/protoc is missing and apache-orc could not find Snappy under thirdparty/installed. - Behavior changed: No - Does this need documentation: No
1 parent 1076dec commit 38eb879

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

‎be/test/format_v2/parquet/parquet_reader_test.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1405,7 +1405,7 @@ TEST_F(NewParquetReaderTest, EmptySelectionUpdatesProfileCounters) {
14051405
auto request = std::make_shared<format::FileScanRequest>();
14061406
request->predicate_columns = {field_projection(0)};
14071407
request->non_predicate_columns = {field_projection(1)};
1408-
request->conjuncts.push_back(create_int32_greater_than_conjunct(0, 10));
1408+
request->conjuncts.push_back(create_int32_sum_greater_than_conjunct(0, 0, 10));
14091409
use_schema_order_positions(request.get(), schema);
14101410
ASSERT_TRUE(reader->open(request).ok());
14111411

0 commit comments

Comments
 (0)