Skip to content

Commit 35724e3

Browse files
committed
[fix](build) Initialize H3 before configuring BE unit tests
### What problem does this PR solve? Problem Summary: The standalone BE unit-test script did not initialize the newly required H3 submodule. A fresh checkout could fail during CMake configuration when the H3 wrapper reads VERSION. Add the same H3 initialization used by build.sh before configuring unit tests. ### Release note None ### Check List (For Author) - Test: bash -n run-be-ut.sh and git diff --check passed; initialization matches build.sh. Fresh-checkout build validation was not run. - Behavior changed: No SQL behavior change; fix standalone unit-test setup. - Does this need documentation: No.
1 parent c9a406b commit 35724e3

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

‎run-be-ut.sh‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -253,12 +253,14 @@ update_submodule() {
253253

254254
# Keep this list in sync with build.sh: be/CMakeLists.txt adds storage/index/ann
255255
# unconditionally, and its cmake-protect target add_subdirectory()s both faiss and openblas,
256-
# so the configure step fails outright when either is missing.
256+
# so the configure step fails outright when either is missing. The H3 wrapper also
257+
# requires its submodule to be initialized before configuring BE.
257258
update_submodule "contrib/datasketches-cpp" "datasketches-cpp" "https://github.com/apache/datasketches-cpp/archive/refs/heads/master.tar.gz"
258259
update_submodule "contrib/apache-orc" "apache-orc" "https://github.com/apache/doris-thirdparty/archive/refs/heads/orc.tar.gz"
259260
update_submodule "contrib/clucene" "clucene" "https://github.com/apache/doris-thirdparty/archive/refs/heads/clucene.tar.gz"
260261
update_submodule "contrib/openblas" "openblas" "https://github.com/apache/doris-thirdparty/archive/refs/heads/openblas.tar.gz"
261262
update_submodule "contrib/faiss" "faiss" "https://github.com/apache/doris-thirdparty/archive/refs/heads/faiss.tar.gz"
263+
update_submodule "contrib/h3" "h3" "https://github.com/uber/h3/archive/refs/tags/v4.5.0.tar.gz"
262264

263265
if [[ "_${DENABLE_CLANG_COVERAGE}" == "_ON" ]]; then
264266
echo "export DORIS_TOOLCHAIN=clang" >>custom_env.sh

0 commit comments

Comments
 (0)