Repository navigation
Commit 3506202
[test](fe) Wait for the peer reclaim queue before checking coalesced requests
### What problem does this PR solve?
Issue Number: None
Related PR: #66717, #67726
Problem Summary: `peerReclaimCoalescesQueuedRequestsToTheLargestAdmission` checked the reclaim
targets as soon as the second reclaim callback counted down its latch. At that point the second
drain is still running: its callback has not returned, and it has not yet decided whether a
request is left for another drain. A regression that leaves a request behind after the coalesced
drain could therefore pass if the next drain ran after the assertion. The test now waits on two
barriers before it checks the targets. Each barrier is a drain of a separate budget manager on the
same process-wide reclaim thread. The first barrier runs after the second drain has finished and
queued anything it left behind; the second runs after that queued drain.
### Release note
None
### Check List (For Author)
- Test: Unit Test
- `MetaCacheBudgetManagerTest` (13) passes locally. With a mutation that keeps the request
pending after a drain and pauses 50 ms at the start of each drain, the previous version of
the test passes, and this version fails with targets `[10, 20, 20, 20]`.
- Behavior changed: No
- Does this need documentation: No
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>1 parent 742c58b commit 3506202
1 file changed
Lines changed: 28 additions & 0 deletions
File tree
- fe/fe-connector/fe-connector-cache/src/test/java/org/apache/doris/connector/cache
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
279 | 279 | | |
280 | 280 | | |
281 | 281 | | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
282 | 286 | | |
283 | 287 | | |
284 | 288 | | |
| |||
453 | 457 | | |
454 | 458 | | |
455 | 459 | | |
| 460 | + | |
| 461 | + | |
| 462 | + | |
| 463 | + | |
| 464 | + | |
| 465 | + | |
| 466 | + | |
| 467 | + | |
| 468 | + | |
| 469 | + | |
| 470 | + | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
| 474 | + | |
| 475 | + | |
| 476 | + | |
| 477 | + | |
| 478 | + | |
| 479 | + | |
| 480 | + | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
456 | 484 | | |
457 | 485 | | |
458 | 486 | | |
| |||
0 commit comments