Repository navigation
Commit 3265322
committed
[fix](variant) Preserve dotted-key encoding in copy-tablet DDL
### Background
ADMIN COPY TABLET generates a CREATE TABLE statement for reading a tablet snapshot at a specific version. The debug table must retain the source table's VARIANT key encoding.
### What problem does this PR solve?
Issue Number: None
Related PR: #69995
PR Type: Bugfix
Problem Summary:
Both specific-version DDL paths returned before emitting variant_escape_dots_in_keys. Reuse the normal DDL property renderer in both paths so debug tables preserve dotted-key lookup semantics.
### Details
- **Frequency:** Copying a tablet from a table with variant_escape_dots_in_keys=true.
- **Root cause:** The specific-version branches emit a reduced property list and bypass normal OLAP properties.
- **Why existing tests missed it:** Copy-tablet DDL was not covered by the escaped-table property tests.
- **Fix:** Share the opt-in property renderer across normal DDL and both specific-version branches.
- **Other paths and branches:** Cover getDdlStmt and getCreateTableLikeStmt; preserve default-false DDL and snapshot version output.
### Testing
- Both new copy-tablet tests fail before the fix on the missing property.
- 13 affected FE test classes: 223 passed, 1 existing @disabled test skipped, zero failures or errors.
- Both entry points cover true/false, single-bucket DDL, replication count, snapshot version, and executing the generated DDL to restore the encoding and visible version.
- FE Checkstyle passed with zero violations.
### Release note
ADMIN COPY TABLET preserves variant_escape_dots_in_keys in generated debug-table DDL.
### Check List (For Author)
- Behavior changed: Yes (copy-tablet DDL preserves the source encoding).
- Does this need documentation: No.
- Pre-submission status: Ready.
### AI Disclosure
- Tool: OpenAI Codex.
- Generated: Code, tests, and commit description.
- Human review: Pending.1 parent b1a24ab commit 3265322
2 files changed
Lines changed: 59 additions & 6 deletions
File tree
- fe/fe-core/src
- main/java/org/apache/doris/catalog
- test/java/org/apache/doris/catalog
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4346 | 4346 | | |
4347 | 4347 | | |
4348 | 4348 | | |
4349 | | - | |
4350 | | - | |
4351 | | - | |
4352 | | - | |
| 4349 | + | |
4353 | 4350 | | |
4354 | 4351 | | |
4355 | 4352 | | |
| |||
4407 | 4404 | | |
4408 | 4405 | | |
4409 | 4406 | | |
| 4407 | + | |
| 4408 | + | |
| 4409 | + | |
| 4410 | + | |
| 4411 | + | |
| 4412 | + | |
| 4413 | + | |
4410 | 4414 | | |
4411 | 4415 | | |
4412 | 4416 | | |
| |||
4516 | 4520 | | |
4517 | 4521 | | |
4518 | 4522 | | |
4519 | | - | |
| 4523 | + | |
| 4524 | + | |
| 4525 | + | |
4520 | 4526 | | |
4521 | 4527 | | |
4522 | 4528 | | |
| |||
4870 | 4876 | | |
4871 | 4877 | | |
4872 | 4878 | | |
4873 | | - | |
| 4879 | + | |
| 4880 | + | |
| 4881 | + | |
4874 | 4882 | | |
4875 | 4883 | | |
4876 | 4884 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| 23 | + | |
23 | 24 | | |
24 | 25 | | |
25 | 26 | | |
26 | 27 | | |
27 | 28 | | |
28 | 29 | | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
29 | 33 | | |
30 | 34 | | |
31 | 35 | | |
| |||
40 | 44 | | |
41 | 45 | | |
42 | 46 | | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
43 | 88 | | |
44 | 89 | | |
45 | 90 | | |
| |||
0 commit comments