You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 2761502
Browse filesBrowse the repository at this point in the historyBrowse files
[feature](arrow-flight) Name a session option as it is read back, and keep the session's queries out of its options
Review round on the session actions.
A session variable is an option under the name GetSessionOptions lists it by,
and only that: the ADBC driver looks an option up in the GetSessionOptions
result by the name the client set it under, so a name SET is lenient about
(another case, an experimental variable without its prefix, a retired variable
kept for old scripts, a hidden one) would be set and never read back. Such a
name is INVALID_NAME now; VariableMgr.getShownVarContext is the SHOW VARIABLES
namespace, shared with dump(). A malformed catalog name is INVALID_VALUE, the
check SWITCH makes first made before the statement, since the executor's
error-code rewriting would report it as ERROR. What that rewriting leaves
unclassifiable for SET is now said in the comments instead of overstated.
A session option action is a command of the session and counts as activity:
callCommand refreshes the session's start time (the timestamp alone, so what
the last statement recorded stays), which also covers the metadata and
prepared statement actions and a frontend-side DoGet. It is no request of the
session, so the last request's cached result and deferred query stay for the
client to pull; for that to be safe, a deferred query now keeps its own query
id and start time (StmtExecutor captures them when it defers, next to the
execution timeout it already froze): it is unregistered under its own id --
the SET statements an option runs give the context a new one, and finalizing
under that leaked the deferred query's registration and instance count -- and
the idle reaper counts from the query's start rather than the session's last
command, as the config's description says.
ListActions names exactly the actions this producer implements, the session
actions included; Arrow's default listed transactions and savepoints Doris
answers UNIMPLEMENTED and left the session actions out.
The regression suite hardcodes its table name and drops it before use only.
Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_01Ja986K4PEm2LD8u44L9jd2
0 commit comments