You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 2358e5e
Browse filesBrowse the repository at this point in the historyBrowse files
[refactor](lance) Remove the durable Lance index job framework (#66497)
Per the updated direction in #66497
(#66497 (comment)),
Lance index mutations move to synchronous SQL with bounded worker
execution modeled on Iceberg rewrite_data_files, and a durable
asynchronous job framework is no longer part of the initial
implementation. This removes it outright rather than leaving it
disabled behind a flag or maintaining two execution paths.
Removed:
- the durable Lance index job state machine, manager, persistent
same-name fences, unresolved-job quotas, and job replay
infrastructure introduced by #67235
- the job-specific parts of #67630: durable job creation and JobId
result sets, SHOW LANCE INDEX JOB(S) with its grammar and plan
wiring, the catalog DDL guards tied to unresolved jobs, and the
Flight SQL JobId result-schema special case for Lance index DDL
- the three unresolved-job quota configuration keys, the job-specific
tests, and the now-unreferenced job-locator resolver pair and
dataset-locator helper on the Lance catalog and client
- stale comments in the retained validation files that still
described the removed framework
Kept and adapted for the synchronous path:
- the privilege, schema, parameter, snapshot, and IF-condition
validation (the LanceIndexAdmission preflight, the static validator,
the schema-contract builder, and the target-aware catalog guard); a
mutation that passes the whole preflight now ends in the shared
not-supported rejection, while an IF preflight no-op completes as a
plain success
- read-only SHOW INDEX, the lance_index_entries TVF, and the
statically validated DDL surface; enable_lance_index_mutation
remains the gate
- the schema-contract and name-normalization helpers, relocated out
of the removed job package; the replay-path target guard keeps
slimmed direct coverage
Compatibility: enable_lance_index_mutation has defaulted to false
since #67630 merged and no released build exposes it enabled, so no
deployment can hold persisted job records. The OP_LANCE_INDEX_JOB_UPSERT
(500) code is kept as a tombstone that is never reused: journals from
builds that manually enabled the gate stay readable through a minimal
consume-and-discard branch (the payload was Text-delimited JSON), and
the image chunk the old manager wrote is skipped through the existing
deprecated-module list, so metadata from previous builds still loads.
0 commit comments