You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 1c28718
Browse filesBrowse the repository at this point in the historyBrowse files
[fix](fe) Split the auto-detect group's bookkeeping out of the table lock
Two follow-ups from the previous commit. The task-group publication ran all of its
bookkeeping under the target table's write lock, which the wrapper holds: that bookkeeping
writes an edit-log entry for every task (an ADD and a DROP each), and with the default
journal durability (SYNC/SYNC/SIMPLE_MAJORITY) every one of them waits for a replica
acknowledgement, so a PARTITION(*) overwrite spanning many partitions kept readers and
writers of the target blocked through all of those waits. And the unit test added for the
dropped-target branch still called the publication method with its pre-refactor signature,
so its reflective call never reached the branch it was written for.
Key changes:
- taskGroupSuccess is split into the replacement and the bookkeeping. The overwrite calls
the replacement under its last-chance lock and the bookkeeping after it; the owner-side
entry point keeps calling the composed method, so that path is unchanged.
- The dropped-target test calls the current method with a publication callback and asserts
the callback was not reached.
Unit Test:
- InsertOverwriteDroppedTargetTest#targetDroppedBeforeTheSwapFailsTheOverwrite
(Tests run: 1, Failures: 0, Errors: 0)
- test_insert_overwrite_cancel, test_iot_auto_detect, test_iot_auto_detect_fail,
test_iot_auto_detect_concurrent and test_iot_overwrite_and_create pass.
Copy file name to clipboardExpand all lines: fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/insert/InsertOverwriteTableCommand.java
+6-2Lines changed: 6 additions & 2 deletions
Original file line number
Diff line number
Diff line change
@@ -153,7 +153,7 @@ public class InsertOverwriteTableCommand extends Command
Copy file name to clipboardExpand all lines: fe/fe-core/src/test/java/org/apache/doris/nereids/trees/plans/commands/insert/InsertOverwriteDroppedTargetTest.java
0 commit comments