Repository navigation
Commit 157fc36
committed
[fix](lance) Address review comments on Lance time travel
- Managed tables: pin every latest read (plain queries, search TVFs,
metadata reads, branch heads) to the newest version the namespace
records, and reject an empty history instead of letting the SDK fall
back to the newest manifest in storage.
- Managed tables: if the SDK opens another location than the cached
table access, drop that access and read once more, so the FE and the
BE use the same location. Hand the SDK the vended options in the
namespace's own spelling so its fresh values replace them key for key.
- FOR TIME AS OF: resolve from manifest commit times for all tables, as
Lance's asof does, choosing only among namespace-recorded versions for
managed tables; fail when the neighbouring version was removed by
cleanup instead of returning an older snapshot; probe a still-staged
recorded version only next to the selection.
- Reject a tag name in FOR VERSION AS OF with every explicit @Branch,
@Branch(main) included.
- Read only the requested tag's file for @tag, deriving its branch from
the checked-out URI.
- Do not report a branch the namespace records as missing when its head
manifest fails to open; use a dedicated exception for "no version at
or before"; ignore null versions; compare table_uri and location
without a trailing slash.
- Point the Linux x86_64 JNI pins at lance-jni-12.0.0-glibc2.17-r1.
- lance_build_time_travel.py: output is optional with --create-branch.1 parent c7f59af commit 157fc36
16 files changed
Lines changed: 631 additions & 152 deletions
File tree
- docker/thirdparties
- docker-compose/iceberg
- scripts
- docs
- fe/fe-core/src
- main/java/org/apache/doris/datasource/lance
- metadata
- storage
- test/java/org/apache/doris/datasource/lance
- storage
- regression-test
- data/external_table_p0/lance
- suites/external_table_p0/lance
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
133 | 133 | | |
134 | 134 | | |
135 | 135 | | |
136 | | - | |
| 136 | + | |
| 137 | + | |
137 | 138 | | |
138 | 139 | | |
139 | 140 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
154 | 154 | | |
155 | 155 | | |
156 | 156 | | |
157 | | - | |
| 157 | + | |
| 158 | + | |
158 | 159 | | |
159 | 160 | | |
160 | 161 | | |
161 | 162 | | |
162 | 163 | | |
163 | 164 | | |
| 165 | + | |
| 166 | + | |
164 | 167 | | |
165 | 168 | | |
166 | 169 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | | - | |
41 | | - | |
| 40 | + | |
| 41 | + | |
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
| |||
112 | 112 | | |
113 | 113 | | |
114 | 114 | | |
115 | | - | |
116 | | - | |
| 115 | + | |
117 | 116 | | |
118 | 117 | | |
119 | 118 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
| 14 | + | |
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| |||
0 commit comments