Repository navigation
Commit 134f35e
committed
[fix](ivm) Rename leftover row binlog to changelog in IVM tests
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #69311, #69268, #63639
Problem Summary: #69311 renamed the row binlog (the change stream IVM
reads) to changelog and rejected the legacy keys `binlog.format` /
`binlog.need_historical_value` in every DDL. Two test files merged just
before it were outside that rename sweep and now fail: the regression
suite `test_ivm_datetime_sequence` (#69268) and the FE unit test
`RelationImpliedPredicateTest#testIvmOutputPredicatesSkipHiddenColumns`
(#63639) still created IVM base tables with `binlog.enable = true` plus
`binlog.format = ROW`, which CREATE TABLE now rejects, and the FE test
also gated on `enable_feature_binlog` instead of the new
`enable_feature_changelog`. Fix: switch both to
`changelog.enable = true` (plus `changelog.need_historical_value` where
needed) and `enable_feature_changelog`; the gate in the regression
cluster conf is covered by the existing CI configuration. Verified
locally: the two FE UT classes pass (35 tests, 0 failures) and the
regression suite passes against a cluster rebuilt from current master
("All suites success", results unchanged so the .out is untouched).
### Release note
None
### Check List (For Author)
- Test: Regression test / Unit Test
- fe: RelationImpliedPredicateTest and IvmUtilTest pass via run-fe-ut.sh
- regression: mtmv_p0 suite test_ivm_datetime_sequence passes via run-regression-test.sh
- Behavior changed: No
- Does this need documentation: No1 parent 73a987e commit 134f35e
2 files changed
Lines changed: 9 additions & 11 deletions
File tree
- fe/fe-core/src/test/java/org/apache/doris/nereids/mv
- regression-test/suites/mtmv_p0/ivm
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
414 | 414 | | |
415 | 415 | | |
416 | 416 | | |
417 | | - | |
| 417 | + | |
418 | 418 | | |
419 | 419 | | |
420 | | - | |
421 | | - | |
| 420 | + | |
| 421 | + | |
422 | 422 | | |
423 | 423 | | |
424 | 424 | | |
425 | 425 | | |
426 | 426 | | |
427 | | - | |
| 427 | + | |
428 | 428 | | |
429 | 429 | | |
430 | 430 | | |
| |||
458 | 458 | | |
459 | 459 | | |
460 | 460 | | |
461 | | - | |
| 461 | + | |
462 | 462 | | |
463 | 463 | | |
464 | 464 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
51 | | - | |
52 | | - | |
53 | | - | |
| 51 | + | |
| 52 | + | |
54 | 53 | | |
55 | 54 | | |
56 | 55 | | |
| |||
64 | 63 | | |
65 | 64 | | |
66 | 65 | | |
67 | | - | |
68 | | - | |
69 | | - | |
| 66 | + | |
| 67 | + | |
70 | 68 | | |
71 | 69 | | |
72 | 70 | | |
| |||
0 commit comments