Repository navigation
Commit 1145d3d
committed
[fix](fe) Recheck split fetch errors after awaited range
### What problem does this PR solve?
Issue Number: None
Problem Summary: A one-split BE fetch can wait for a range, then receive that range after its producer has already published a failure or cancellation. The new per-split queue path appended the awaited range and returned as soon as the request filled, without rechecking terminal state. Recheck after notifying queue space so an already-failed assignment returns its error and a stopped assignment discards the range. A deterministic two-case test reproduced the previous incorrect return and passes with the fix.
### Release note
None
### Check List (For Author)
- Test: Unit Test. The new race test failed in both cases before the fix, then passed in both cases afterward. All 33 SplitSourceTest cases passed using the prior Surefire classpath and JUnit launcher. The local FE-core Maven route is blocked by unresolved snapshot reactor artifacts; the full reactor needs an x86 gRPC generator unavailable on this ARM host.
- Behavior changed: Yes (an already-failed or cancelled one-split fetch no longer returns OK with a range)
- Does this need documentation: No1 parent 5a8470c commit 1145d3d
2 files changed
Lines changed: 43 additions & 0 deletions
File tree
- fe/fe-core/src
- main/java/org/apache/doris/datasource/split
- test/java/org/apache/doris/datasource/split
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
124 | 124 | | |
125 | 125 | | |
126 | 126 | | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
127 | 134 | | |
128 | 135 | | |
129 | 136 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
248 | 248 | | |
249 | 249 | | |
250 | 250 | | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
251 | 287 | | |
252 | 288 | | |
253 | 289 | | |
| |||
0 commit comments