Skip to content

Commit 0166cc4

Browse files
committed
[fix](regression) Align UUID folding assertions with the skip policy
### What problem does this PR solve? Issue Number: N/A Related PR: #67627 Problem Summary: The scalar matrix expects BE folding to remove UUID_VERSION on a constant UUID, but the recursive UUID skip policy keeps that expression for runtime evaluation. Require UUID_VERSION to remain in all three folding settings, retain the CONCAT folding checks, and clarify that the matrix configures folding modes without promising UUID folding. The separate integer element_at control continues to verify BE folding. ### Release note None ### Check List (For Author) - Test: Regression test / Manual test - test_uuid_scalar_matrix and test_uuid_be_fold_skip passed using run-regression-test.sh and the existing golden files. - EXPLAIN VERBOSE confirmed UUID_VERSION remains with BE folding enabled. - git diff --check passed. - Behavior changed: No, test assertions only - Does this need documentation: No
1 parent 762ec04 commit 0166cc4

1 file changed

Lines changed: 3 additions & 7 deletions

File tree

‎regression-test/suites/datatype_p0/uuid/test_uuid_scalar_matrix.groovy‎

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
// specific language governing permissions and limitations
1616
// under the License.
1717

18-
// All constant/column masks, with FE folding, BE folding and folding disabled.
18+
// All constant/column masks under FE-only, FE+BE and disabled folding settings.
1919
suite("test_uuid_scalar_matrix", "p0") {
2020
def matrix = this.evaluate(new File(context.file.parentFile, "uuid_matrix.groovy"))
2121
sql "DROP TABLE IF EXISTS uuid_matrix_scalar"
@@ -60,16 +60,12 @@ suite("test_uuid_scalar_matrix", "p0") {
6060
explain {
6161
sql "verbose ${foldQuery}"
6262
contains "coalesce(u["
63+
// UUID descendants keep UUID_VERSION at runtime even when BE folding is enabled.
64+
contains "uuid_version("
6365
if (mode == 'runtime') {
6466
contains "concat('550E8400'"
65-
contains "uuid_version("
6667
} else {
6768
notContains "concat('550E8400'"
68-
if (mode == 'be') {
69-
notContains "uuid_version("
70-
} else {
71-
contains "uuid_version("
72-
}
7369
}
7470
}
7571
qt_fold_path foldQuery

0 commit comments

Comments
 (0)