Repository navigation
Commit 00befb0
[fix](ivm) Correct the margin in the description of ivm_stream_keepalive_interval_second
### What problem does this PR solve?
Issue Number: None
Related PR: #69831
Problem Summary:
The description of `ivm_stream_keepalive_interval_second` asked for an interval of at most half the shortest `changelog.ttl_seconds` of the IVM base tables, a bound that leaves a refresh no time. A partition is renewed at the first check after less than half the TTL is left, so when an idle partition is written, the newer of its offset and its keep-alive TSO is up to half the TTL plus one interval old, and one interval older for each check that could not renew it: a round that cannot reach MetaService, finds a lock busy or fails to get a TSO records nothing and leaves the partition to the next one. After the write the partition is not renewed any more, and the refresh that reads the write falls back to COMPLETE (a strict INCREMENTAL refresh fails) once that TSO is older than the TTL. So a refresh is sure to be incremental only if it starts within half the TTL minus the interval after the write, one interval less for each check that could not renew the partition: 11 hours 50 minutes with the defaults (a TTL of a day, 600 seconds), and no time at all at the bound the description gave.
The description now states that time and asks for an interval well under half the TTL. A failed round is still left to the next one: retrying it sooner would not change the bound, and a cloud round first advances MetaService's TSO fence, so a faster retry while MetaService is failing would write to it more often.
### Release note
None
### Check List (For Author)
- Test: No need to test (only the description of a config changes); checkstyle passes for fe-common.
- Behavior changed: No
- Does this need documentation: No
Co-Authored-By: Claude Opus 5.5 <[email protected]>1 parent bcbfdd1 commit 00befb0
1 file changed
Lines changed: 9 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3184 | 3184 | | |
3185 | 3185 | | |
3186 | 3186 | | |
3187 | | - | |
3188 | | - | |
3189 | | - | |
3190 | | - | |
3191 | | - | |
3192 | | - | |
| 3187 | + | |
| 3188 | + | |
| 3189 | + | |
| 3190 | + | |
| 3191 | + | |
| 3192 | + | |
| 3193 | + | |
| 3194 | + | |
| 3195 | + | |
3193 | 3196 | | |
3194 | 3197 | | |
3195 | 3198 | | |
| |||
0 commit comments