-
Notifications
You must be signed in to change notification settings - Fork 5k
[Fix-17579][Workflow] fix view variable error after setting startup parameters for workflow instance #17583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…arameters for workflow instance
|
@ruanwenjun cc, please help review it when you have time, thank you |
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
SbloodyS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ruanwenjun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Will be released at 3.3.2 |
…arameters for workflow instance (apache#17583) (cherry picked from commit 0862515)
…arameters for workflow instance (#17583) (#17594) (cherry picked from commit 0862515) Co-authored-by: huangsheng <[email protected]>
…arameters for workflow instance (apache#17583)
Purpose of the pull request
close #17579
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
This change added tests and can be verified as follows:
ut:
org.apache.dolphinscheduler.api.service.WorkflowInstanceServiceTest#testViewVariablesWithStartingParamThe variables of workflow instance can be viewed normally

(or)
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md