Skip to content

Conversation

@Mrhs121
Copy link
Contributor

@Mrhs121 Mrhs121 commented Oct 16, 2025

Purpose of the pull request

close #17579

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

This change added tests and can be verified as follows:
ut: org.apache.dolphinscheduler.api.service.WorkflowInstanceServiceTest#testViewVariablesWithStartingParam

The variables of workflow instance can be viewed normally
截屏2025-10-16 14 22 06

(or)

Pull Request Notice

Pull Request Notice

If your pull request contains incompatible change, you should also add it to docs/docs/en/guide/upgrade/incompatible.md

@Mrhs121
Copy link
Contributor Author

Mrhs121 commented Oct 16, 2025

@ruanwenjun cc, please help review it when you have time, thank you

@SbloodyS SbloodyS added the bug Something isn't working label Oct 17, 2025
@SbloodyS SbloodyS added this to the 3.3.2 milestone Oct 17, 2025
@SbloodyS SbloodyS requested a review from ruanwenjun October 17, 2025 09:16
@sonarqubecloud
Copy link

Please retry analysis of this Pull-Request directly on SonarQube Cloud

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun merged commit 0862515 into apache:dev Oct 20, 2025
71 of 72 checks passed
@ruanwenjun
Copy link
Member

Will be released at 3.3.2

ruanwenjun pushed a commit to ruanwenjun/dolphinscheduler that referenced this pull request Oct 22, 2025
…arameters for workflow instance (apache#17583)

(cherry picked from commit 0862515)
ruanwenjun added a commit that referenced this pull request Oct 22, 2025
…arameters for workflow instance (#17583) (#17594)

(cherry picked from commit 0862515)

Co-authored-by: huangsheng <[email protected]>
davidzollo pushed a commit to davidzollo/dolphinscheduler that referenced this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend bug Something isn't working test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [Workflow Instance] Setting any startup parameters for the workflow run, and an error occurs when opening the workflow instance

3 participants