-
Notifications
You must be signed in to change notification settings - Fork 5k
[Fix-17575][Workflow] Add a check for duplicate task names when saving or updating a workflow. #17576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
In the code, there are numerous Map data structures that use task names as key values.
|
| if (!taskNameSet.add(taskDefinitionLog.getName())) { | ||
| log.error( | ||
| "Generate task definition list failed, the given task definition name is duplicate, taskName: {}, taskDefinition: {}", | ||
| taskDefinitionLog.getName(), taskDefinitionLog); |
Check failure
Code scanning / CodeQL
Log Injection High
user-provided value
This log entry depends on a
user-provided value
|
ruanwenjun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SbloodyS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
…g or updating a workflow (apache#17576)


Purpose of the pull request
close #17575
Brief change log
Add a check for duplicate task names when saving or updating a workflow.
Verify this pull request
This change added tests and can be verified as follows:
When creating tasks with the same name, a prompt message will be displayed.
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md