[Improvement-17506][dao] Add index on column workflow_definition_code for table t_ds_schedules to reduce time cost when access db #17513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for table t_ds_schedules to reduce time cost when access db
unigof
requested review from
EricGao888,
SbloodyS and
ruanwenjun
as code owners
SbloodyS
reviewed
Sep 16, 2025
Member
SbloodyS
left a comment
SbloodyS
left a comment
There was a problem hiding this comment.
Please add these to upgrade sql.
ruanwenjun
reviewed
Sep 16, 2025
dolphinscheduler-dao/src/main/resources/sql/upgrade/3.3.0_schema/mysql/dolphinscheduler_ddl.sql
Outdated
Show resolved
Hide resolved
...cheduler-dao/src/main/resources/sql/upgrade/3.3.0_schema/postgresql/dolphinscheduler_ddl.sql
Outdated
Show resolved
Hide resolved
dolphinscheduler-dao/src/main/resources/sql/dolphinscheduler_postgresql.sql
Outdated
Show resolved
Hide resolved
Contributor
Author
done. Please take a look, thanks @ruanwenjun |
Contributor
Author
|
Fixed same index name in h2 and postgresql. Could you help to run test again? @ruanwenjun thanks |
ruanwenjun
previously approved these changes
Sep 20, 2025
dolphinscheduler-dao/src/main/resources/sql/upgrade/3.3.2_schema/mysql/dolphinscheduler_ddl.sql
Outdated
Show resolved
Hide resolved
|
ruanwenjun
approved these changes
Sep 26, 2025
davidzollo
pushed a commit
to davidzollo/dolphinscheduler
that referenced
this pull request
Oct 27, 2025
… for table t_ds_schedules to reduce time cost when access db (apache#17513)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
close #17506
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md