Skip to content

Conversation

@ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented Sep 4, 2025

Purpose of the pull request

close #17477

Brief change log

  • When the workflow exist failover instance, we shouldn't support detele it
  • When the subworkflow instance status is submitted, we should trigger it again, when failover a sub workflow task instance
  • Remove unused code
  • Optimize WorkflowExecutionStatus, make it easy to add new enum.
  • When the sub workflow instance state is SUBMITTED, will not trigger it again, only wait it launched.

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contains incompatible change, you should also add it to docs/docs/en/guide/upgrade/incompatible.md

@ruanwenjun ruanwenjun added this to the 3.3.2 milestone Sep 4, 2025
@ruanwenjun ruanwenjun marked this pull request as draft September 5, 2025 04:14
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixWorkflowExecutionStatus branch from 22fb0b2 to 76b626e Compare September 5, 2025 17:04
@ruanwenjun ruanwenjun marked this pull request as ready for review September 5, 2025 17:06
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixWorkflowExecutionStatus branch 2 times, most recently from 955f46b to ef26fe2 Compare September 5, 2025 17:06
@ruanwenjun
Copy link
Member Author

@reele Please take a look, I have changed some failover logic related to sub workflow.

@ruanwenjun ruanwenjun added the bug Something isn't working label Sep 6, 2025
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixWorkflowExecutionStatus branch 3 times, most recently from 7f2b2a8 to 6dfae10 Compare September 7, 2025 04:01
@reele
Copy link
Contributor

reele commented Sep 8, 2025

@reele Please take a look, I have changed some failover logic related to sub workflow.

LGTM

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixWorkflowExecutionStatus branch from 6dfae10 to ddc57fd Compare September 8, 2025 11:31
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixWorkflowExecutionStatus branch 2 times, most recently from d051e1c to ade24fd Compare September 11, 2025 15:02
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixWorkflowExecutionStatus branch 2 times, most recently from 2950776 to ba0622e Compare September 15, 2025 13:27
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixWorkflowExecutionStatus branch from ba0622e to 683f93f Compare September 15, 2025 15:01
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
49.0% Coverage on New Code (required ≥ 60%)

See analysis details on SonarQube Cloud

@SbloodyS SbloodyS merged commit 6221f02 into apache:dev Sep 16, 2025
74 of 77 checks passed
davidzollo pushed a commit to davidzollo/dolphinscheduler that referenced this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Workflow can be deleted which contains failover instance

4 participants