-
Notifications
You must be signed in to change notification settings - Fork 5k
[Fix-17477] Fix workflow can be deleted which contains failover instance #17478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SbloodyS
merged 2 commits into
apache:dev
from
ruanwenjun:dev_wenjun_fixWorkflowExecutionStatus
Sep 16, 2025
Merged
[Fix-17477] Fix workflow can be deleted which contains failover instance #17478
SbloodyS
merged 2 commits into
apache:dev
from
ruanwenjun:dev_wenjun_fixWorkflowExecutionStatus
Sep 16, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22fb0b2 to
76b626e
Compare
955f46b to
ef26fe2
Compare
Member
Author
|
@reele Please take a look, I have changed some failover logic related to sub workflow. |
7f2b2a8 to
6dfae10
Compare
Contributor
LGTM |
6dfae10 to
ddc57fd
Compare
SbloodyS
approved these changes
Sep 9, 2025
Member
SbloodyS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d051e1c to
ade24fd
Compare
zhongjiajie
approved these changes
Sep 15, 2025
2950776 to
ba0622e
Compare
ba0622e to
683f93f
Compare
|
davidzollo
pushed a commit
to davidzollo/dolphinscheduler
that referenced
this pull request
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Purpose of the pull request
close #17477
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md