Skip to content

Conversation

@njnu-seafish
Copy link
Contributor

Purpose of the pull request

close #17469

Brief change log

Perform resource cleanup operations in the afterCompletion method

Verify this pull request

Pull Request Notice

Pull Request Notice

If your pull request contains incompatible change, you should also add it to docs/docs/en/guide/upgrade/incompatible.md

@njnu-seafish njnu-seafish changed the title [Fix-17469]Fix threadLocal bug [Fix-17469]Fix threadLocal bug in LoginHandlerInterceptor Sep 4, 2025
@SbloodyS SbloodyS added this to the 3.3.2 milestone Sep 4, 2025
@SbloodyS SbloodyS added the bug Something isn't working label Sep 4, 2025
@SbloodyS SbloodyS requested a review from ruanwenjun September 4, 2025 08:22
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun changed the title [Fix-17469]Fix threadLocal bug in LoginHandlerInterceptor [Fix-17469]Fix threadLocal will not remove if exception occur in LoginHandlerInterceptor Sep 4, 2025
@ruanwenjun ruanwenjun changed the title [Fix-17469]Fix threadLocal will not remove if exception occur in LoginHandlerInterceptor [Fix-17469]Fix threadLocal will not clean if exception occur in LoginHandlerInterceptor Sep 4, 2025
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2025

@SbloodyS SbloodyS merged commit 8ebc6f3 into apache:dev Sep 8, 2025
72 checks passed
davidzollo pushed a commit to davidzollo/dolphinscheduler that referenced this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [API] LoginHandlerInterceptor has a possibility of memory leak

3 participants