Skip to content

Conversation

@Zzih96
Copy link
Contributor

@Zzih96 Zzih96 commented Aug 28, 2025

Purpose of the pull request

fix #17451

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contains incompatible change, you should also add it to docs/docs/en/guide/upgrade/incompatible.md

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix this in SqlTask

taskExecutionContext.setVarPool(sqlParameters.getVarPool());

Rather than create a common method.

Before adding the common varpool handling, it is best to modify the task plugin's return result to explicitly return the varpool. Otherwise, we are essentially repeatedly modifying a variable, which is prone to causing problems.

@ruanwenjun ruanwenjun changed the title [Fix-17406]Fix Parameter passing feature is unavailable [Fix-17406]Fix Parameter passing feature is unavailable in SQL Task Aug 28, 2025
@ruanwenjun
Copy link
Member

And it's possible to add E2E for this case? This seems to only require adding a new case to the current E2E template.

@SbloodyS SbloodyS added the bug Something isn't working label Aug 28, 2025
@SbloodyS SbloodyS added this to the 3.3.2 milestone Aug 28, 2025
@Zzih96
Copy link
Contributor Author

Zzih96 commented Aug 28, 2025

Please fix this in SqlTask

taskExecutionContext.setVarPool(sqlParameters.getVarPool());

Rather than create a common method.

Before adding the common varpool handling, it is best to modify the task plugin's return result to explicitly return the varpool. Otherwise, we are essentially repeatedly modifying a variable, which is prone to causing problems.

Is it about adding varPool replacement in each task (such as SqlTask), rather than handling it uniformly in PhysicalTaskExecutor?

@ruanwenjun
Copy link
Member

Please fix this in SqlTask

taskExecutionContext.setVarPool(sqlParameters.getVarPool());

Rather than create a common method.
Before adding the common varpool handling, it is best to modify the task plugin's return result to explicitly return the varpool. Otherwise, we are essentially repeatedly modifying a variable, which is prone to causing problems.

Is it about adding varPool replacement in each task (such as SqlTask), rather than handling it uniformly in PhysicalTaskExecutor?

Yes

@Zzih96 Zzih96 requested a review from Gallardot as a code owner September 4, 2025 09:29
@github-actions github-actions bot added the test label Sep 4, 2025

@Test
void testVarPoolSetting() {
// 创建包含OUT参数的SqlParameters
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove Chinese here.

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun force-pushed the fix-parameter branch 2 times, most recently from 593a561 to efe9e39 Compare September 10, 2025 13:36
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 60%)

See analysis details on SonarQube Cloud

@SbloodyS SbloodyS merged commit e066793 into apache:dev Sep 17, 2025
75 of 78 checks passed
davidzollo pushed a commit to davidzollo/dolphinscheduler that referenced this pull request Oct 27, 2025
@SbloodyS SbloodyS changed the title [Fix-17406]Fix Parameter passing feature is unavailable in SQL Task [Fix-17451]Fix Parameter passing feature is unavailable in SQL Task Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [Master] Parameter passing feature is unavailable in SQL Task

4 participants