-
Notifications
You must be signed in to change notification settings - Fork 5k
[Fix-17451]Fix Parameter passing feature is unavailable in SQL Task #17456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ruanwenjun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix this in SqlTask
taskExecutionContext.setVarPool(sqlParameters.getVarPool());
Rather than create a common method.
Before adding the common varpool handling, it is best to modify the task plugin's return result to explicitly return the varpool. Otherwise, we are essentially repeatedly modifying a variable, which is prone to causing problems.
|
And it's possible to add E2E for this case? This seems to only require adding a new case to the current E2E template. |
Is it about adding varPool replacement in each task (such as |
Yes |
|
|
||
| @Test | ||
| void testVarPoolSetting() { | ||
| // 创建包含OUT参数的SqlParameters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove Chinese here.
ruanwenjun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
593a561 to
efe9e39
Compare
efe9e39 to
4694bb8
Compare
SbloodyS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|


Purpose of the pull request
fix #17451
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md