Skip to content

Conversation

@Calvin979
Copy link
Contributor

@Calvin979 Calvin979 commented Aug 15, 2025

Purpose of the pull request

Complete development documentations. Closed #17426

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contains incompatible change, you should also add it to docs/docs/en/guide/upgrade/incompatible.md

@boring-cyborg
Copy link

boring-cyborg bot commented Aug 15, 2025

ruanwenjun
ruanwenjun previously approved these changes Aug 16, 2025
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@ruanwenjun ruanwenjun added the improvement make more easy to user or prompt friendly label Aug 16, 2025
@ruanwenjun ruanwenjun added this to the 3.3.1 milestone Aug 16, 2025
@ruanwenjun ruanwenjun force-pushed the fix_dev_documentation branch from 22254fa to 8b08088 Compare August 16, 2025 07:15
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should change the node version to node 16.x.x and pnpm version to pnpm 7.x.x.

@Calvin979
Copy link
Contributor Author

We should change the node version to node 16.x.x and pnpm version to pnpm 7.x.x.

@SbloodyS
Done. I changed pnpm version to 8.0+ by the way, because there is a compatibility problem with Node.js.
For you reference: https://pnpm.io/installation#compatibility

@Calvin979 Calvin979 requested a review from SbloodyS August 19, 2025 14:55
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@SbloodyS SbloodyS merged commit 76545e7 into apache:dev Aug 20, 2025
34 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 20, 2025

Awesome work, congrats on your first merged pull request!

davidzollo pushed a commit to davidzollo/dolphinscheduler that referenced this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

document improvement make more easy to user or prompt friendly priority:high

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Doc][docs] Failed to start up FE by following development guide

4 participants