Skip to content

Conversation

@reele
Copy link
Contributor

@reele reele commented Jul 30, 2025

Purpose of the pull request

close #17353

Brief change log

ignore need-fault-tolerance state in findLastTaskInstances and findLastTaskInstance of TaskInstanceMapper.xml

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contains incompatible change, you should also add it to docs/docs/en/guide/upgrade/incompatible.md

@SbloodyS SbloodyS added the bug Something isn't working label Jul 30, 2025
@SbloodyS SbloodyS added this to the 3.3.1 milestone Jul 30, 2025
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun merged commit a5c20a0 into apache:dev Jul 30, 2025
70 checks passed
@ruanwenjun
Copy link
Member

This is caused by we think the failover state is a failure state, we may need to remove the failover state from isFailure

eco8848 pushed a commit to eco8848/dolphinscheduler that referenced this pull request Aug 8, 2025
davidzollo pushed a commit to davidzollo/dolphinscheduler that referenced this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [DependentExecute] Result calculation of task-instance should ignore need-fault-tolerance state

3 participants