[Chore][Master] Rename methods in StateAction for better readability. #17379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

SbloodyS merged 1 commit into apache:dev from Sud0x67:dev-rename

Jul 29, 2025

Contributor

Sud0x67 commented Jul 28, 2025 •

edited by SbloodyS

Loading

Purpose of the pull request

Rename methods in TaskStateActions and WorkflowStateActions for better readability.

Brief change log

Rename methods xxxEventAction to onXxxEvent in TaskStateActions and WorkflowStateActions for better readability.

close #17377

Verify this pull request

This pull request is code cleanup without any test coverage.


          [Chore-17377][Master] Rename methods in StateAction for better readab…

5d27df6

…ility.

Sud0x67 requested review from SbloodyS, caishunfeng and ruanwenjun as code owners

July 28, 2025 14:12

boring-cyborg bot commented Jul 28, 2025

Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)

github-actions bot added the backend label

github-actions bot assigned Sud0x67

Sud0x67 changed the title ~~[Chore-17377][Master] Rename methods in StateAction for better readability.~~ [Chore-17379][Master] Rename methods in StateAction for better readability.

Sud0x67 changed the title ~~[Chore-17379][Master] Rename methods in StateAction for better readability.~~ [Chore][Master] Rename methods in StateAction for better readability.

ruanwenjun added the chore label

ruanwenjun approved these changes

View reviewed changes

Member

ruanwenjun left a comment

LGTM

github-advanced-security bot found potential problems

View reviewed changes

...ava/org/apache/dolphinscheduler/server/master/engine/task/statemachine/ITaskStateAction.java

    
                  void startedEventAction(final IWorkflowExecutionRunnable workflowExecutionRunnable,

                                          final ITaskExecutionRunnable taskExecutionRunnable,

                                          final TaskRunningLifecycleEvent taskRunningEvent);

                  void onStartedEvent(final IWorkflowExecutionRunnable workflowExecutionRunnable,

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'workflowExecutionRunnable' is never used.

...ava/org/apache/dolphinscheduler/server/master/engine/task/statemachine/ITaskStateAction.java

    
                  void runtimeContextChangedEventAction(final IWorkflowExecutionRunnable workflowExecutionRunnable,

                                                        final ITaskExecutionRunnable taskExecutionRunnable,

                                                        final TaskRuntimeContextChangedEvent taskRuntimeContextChangedEvent);

                  void onRuntimeContextChangedEvent(final IWorkflowExecutionRunnable workflowExecutionRunnable,

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'workflowExecutionRunnable' is never used.

...ava/org/apache/dolphinscheduler/server/master/engine/task/statemachine/ITaskStateAction.java

    
                  void retryEventAction(final IWorkflowExecutionRunnable workflowExecutionRunnable,

                                        final ITaskExecutionRunnable taskExecutionRunnable,

                                        final TaskRetryLifecycleEvent taskRetryEvent);

                  void onRetryEvent(final IWorkflowExecutionRunnable workflowExecutionRunnable,

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'workflowExecutionRunnable' is never used.

...ava/org/apache/dolphinscheduler/server/master/engine/task/statemachine/ITaskStateAction.java

    
                  void dispatchEventAction(final IWorkflowExecutionRunnable workflowExecutionRunnable,

                                           final ITaskExecutionRunnable taskExecutionRunnable,

                                           final TaskDispatchLifecycleEvent taskDispatchEvent);

                  void onDispatchEvent(final IWorkflowExecutionRunnable workflowExecutionRunnable,

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'workflowExecutionRunnable' is never used.

...ava/org/apache/dolphinscheduler/server/master/engine/task/statemachine/ITaskStateAction.java

    
                  void failoverEventAction(final IWorkflowExecutionRunnable workflowExecutionRunnable,

                                           final ITaskExecutionRunnable taskExecutionRunnable,

                                           final TaskFailoverLifecycleEvent taskFailoverEvent);

                  void onFailoverEvent(final IWorkflowExecutionRunnable workflowExecutionRunnable,

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'workflowExecutionRunnable' is never used.

sonarqubecloud bot commented Jul 28, 2025

Quality Gate failed

Failed conditions
68.1% Duplication on New Code (required ≤ 10%)

See analysis details on SonarQube Cloud

SbloodyS added the first time contributor label

SbloodyS added this to the 3.3.1 milestone

SbloodyS approved these changes

View reviewed changes

Member

SbloodyS left a comment

+1

SbloodyS merged commit 291adfb into apache:dev

70 of 73 checks passed

boring-cyborg bot commented Jul 29, 2025

Awesome work, congrats on your first merged pull request!

eco8848 pushed a commit to eco8848/dolphinscheduler that referenced this pull request


          [Chore-17377][Master] Rename methods in StateAction for better readab…

d3d937e

…ility. (apache#17379)

davidzollo pushed a commit to davidzollo/dolphinscheduler that referenced this pull request


          [Chore-17377][Master] Rename methods in StateAction for better readab…

c4c25bc

…ility. (apache#17379)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend chore first time contributor