[Improvement-17361][TaskPlugin] Use logger marker to exclude the system log in task instance log content. #17378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanwenjun
requested review from
Gallardot,
SbloodyS and
caishunfeng
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| "{}" + | ||
| "\n****************************** Script Content *****************************************************************\n", | ||
| finalScript); | ||
| log.info("Final Script Content:\n====================\n{}\n====================", finalScript); |
Check failure
Code scanning / CodeQL
Insertion of sensitive information into log files High
Sud0x67
reviewed
Jul 29, 2025
| log.info("Begin to initialize taskContext"); | ||
| taskExecutionContext.setStartTime(System.currentTimeMillis()); | ||
| log.info("End initialize taskContext {}", JSONUtils.toPrettyJsonString(taskExecutionContext)); | ||
| log.info(TaskLogMarkers.excludeInTaskLog(), "{}", JSONUtils.toJsonString(taskExecutionContext)); |
Contributor
There was a problem hiding this comment.
May log.info(TaskLogMarkers.excludeInTaskLog(), "Initialized taskContext {}", JSONUtils.toJsonString(taskExecutionContext)); is better?
ruanwenjun
force-pushed
the
dev_wenjun_fix17361
branch
from
ffab324 to
47b644e
Compare
Contributor
|
LGTM |
ruanwenjun
force-pushed
the
dev_wenjun_fix17361
branch
2 times, most recently
from
2df24ef to
e50d2d8
Compare
SbloodyS
approved these changes
Aug 5, 2025
Gallardot
approved these changes
Aug 5, 2025
ruanwenjun
force-pushed
the
dev_wenjun_fix17361
branch
from
e50d2d8 to
318df43
Compare
… in task instance log content.
ruanwenjun
force-pushed
the
dev_wenjun_fix17361
branch
from
318df43 to
b01750e
Compare
|
3 tasks
eco8848
pushed a commit
to eco8848/dolphinscheduler
that referenced
this pull request
Aug 8, 2025
…em log in task instance log content. (apache#17378)
davidzollo
pushed a commit
to davidzollo/dolphinscheduler
that referenced
this pull request
Oct 27, 2025
…em log in task instance log content. (apache#17378)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
close #17361
Brief change log
Remove some info in task instance log, the user doesn't need to know the engine detail.
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md