Skip to content

Conversation

@reele
Copy link
Contributor

@reele reele commented Jul 21, 2025

Purpose of the pull request

close #17350 .

Brief change log

  1. remove queryMainWorkflowByHostAndStatus
  2. revert queryNeedFailoverWorkflowInstances, all workflow instances still failover in FailoverCoordinator
  3. SubWorkflowLogicTask only takeover old workflow-instance or trigger new workflow-instance

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contains incompatible change, you should also add it to docs/docs/en/guide/upgrade/incompatible.md

ruanwenjun
ruanwenjun previously approved these changes Jul 22, 2025
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun added the bug Something isn't working label Jul 22, 2025
@ruanwenjun ruanwenjun added this to the 3.3.1 milestone Jul 22, 2025
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check failed tests. @reele

@sonarqubecloud
Copy link

@reele
Copy link
Contributor Author

reele commented Jul 24, 2025

Please check failed tests. @reele

fixed.

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun merged commit 5d63e41 into apache:dev Jul 25, 2025
70 checks passed
eco8848 pushed a commit to eco8848/dolphinscheduler that referenced this pull request Aug 8, 2025
davidzollo pushed a commit to davidzollo/dolphinscheduler that referenced this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend bug Something isn't working test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [FailoverCoordinator] Sub workflow won't be failover when parent workflow is healthy.

3 participants