[Improvement-17311][RPC] Validate the args type in RPC method #17312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjfanning
reviewed
Jul 1, 2025
| args = null; | ||
| } else { | ||
| args = new Object[standardRpcRequest.getArgs().length]; | ||
| if (!methodInvoker.isParameterTypeValidated(standardRpcRequest.getArgsTypes())) { |
Member
There was a problem hiding this comment.
minor nit: this can happen 1 line earlier before the args assignment
pjfanning
reviewed
Jul 1, 2025
| if (argType == null) { | ||
| continue; | ||
| } | ||
| if (parameterTypes.get(i) != argType) { |
Member
There was a problem hiding this comment.
one option here is to use https://docs.oracle.com/javase/8/docs/api/java/lang/Class.html#isAssignableFrom-java.lang.Class-
- this would allow subclasses to be accepted
- the current check only works if the classes are an exact match
The if would look something like:
if (parameterTypes.get(i).isAssignableFrom(argType)
This is worth testing because I have a habit of getting this check the wrong way around.
Member
Author
There was a problem hiding this comment.
Great suggestions, thank you!
ruanwenjun
force-pushed
the
dev_wenjun_fixUserCanCustomRpcArgsType
branch
from
a465d27 to
4841a30
Compare
|
ruanwenjun
changed the title
zhongjiajie
approved these changes
Jul 7, 2025
eco8848
pushed a commit
to eco8848/dolphinscheduler
that referenced
this pull request
Aug 8, 2025
davidzollo
pushed a commit
to davidzollo/dolphinscheduler
that referenced
this pull request
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
close #17311
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md