Skip to content

Conversation

@pjfanning
Copy link
Member

@pjfanning pjfanning commented Jun 30, 2025

Purpose of the pull request

fix #17302

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contains incompatible change, you should also add it to docs/docs/en/guide/upgrade/incompatible.md

@pjfanning pjfanning requested a review from SbloodyS as a code owner June 30, 2025 10:21
@SbloodyS SbloodyS added the improvement make more easy to user or prompt friendly label Jun 30, 2025
@SbloodyS SbloodyS added this to the 3.3.1 milestone Jun 30, 2025
@SbloodyS SbloodyS changed the title [Fix-17302][Alert] simplify double handling in ExcelUtils [Improvement-17302][Alert] simplify double handling in ExcelUtils Jun 30, 2025
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gallardot Gallardot added 3.3.0 and removed 3.3.0 labels Jun 30, 2025
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 1, 2025

@SbloodyS SbloodyS merged commit 2ed3821 into apache:dev Jul 1, 2025
70 checks passed
eco8848 pushed a commit to eco8848/dolphinscheduler that referenced this pull request Aug 8, 2025
davidzollo pushed a commit to davidzollo/dolphinscheduler that referenced this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend improvement make more easy to user or prompt friendly ready-to-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement][Master] DS Excel code has unnecessarily complicated double handling

4 participants