Skip to content

Conversation

@ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented Jun 5, 2025

Purpose of the pull request

close #17267

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contains incompatible change, you should also add it to docs/docs/en/guide/upgrade/incompatible.md

@ruanwenjun ruanwenjun self-assigned this Jun 5, 2025
@ruanwenjun ruanwenjun marked this pull request as draft June 5, 2025 15:40
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_throwExceptionIfParseJsonFailed branch 4 times, most recently from 520eda6 to e2445ca Compare June 9, 2025 14:38
@ruanwenjun ruanwenjun added the improvement make more easy to user or prompt friendly label Jun 9, 2025
@ruanwenjun ruanwenjun added this to the 3.3.1 milestone Jun 9, 2025
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_throwExceptionIfParseJsonFailed branch 7 times, most recently from e0c7b12 to 4c5bfac Compare June 20, 2025 10:28
@ruanwenjun ruanwenjun changed the title Throw exception if deserialize json failed [Improvement-17267] Throw exception if deserialize json failed Jun 20, 2025
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_throwExceptionIfParseJsonFailed branch from 4c5bfac to 32f7aa1 Compare June 20, 2025 10:47
@github-actions github-actions bot added the e2e e2e test label Jun 20, 2025
@ruanwenjun ruanwenjun changed the title [Improvement-17267] Throw exception if deserialize json failed [Improvement-17267] Throw exception if deserialize json failed in JSONUtils Jun 20, 2025
@ruanwenjun ruanwenjun marked this pull request as ready for review June 20, 2025 10:50
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_throwExceptionIfParseJsonFailed branch 3 times, most recently from 471a7d3 to cc7969c Compare June 23, 2025 07:26
@github-actions github-actions bot removed the e2e e2e test label Jun 23, 2025
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_throwExceptionIfParseJsonFailed branch from cbd779c to 2cd9b88 Compare June 24, 2025 06:32
@github-actions github-actions bot added the e2e e2e test label Jun 24, 2025
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_throwExceptionIfParseJsonFailed branch 4 times, most recently from 93f0c80 to 5c87e6d Compare June 24, 2025 08:41
@github-actions github-actions bot removed the e2e e2e test label Jun 24, 2025
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_throwExceptionIfParseJsonFailed branch from 5c87e6d to a525ff2 Compare June 25, 2025 10:46
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_throwExceptionIfParseJsonFailed branch from a525ff2 to 8230dfa Compare June 25, 2025 11:44
@sonarqubecloud
Copy link

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gallardot Gallardot merged commit 79f686f into apache:dev Jun 26, 2025
72 of 74 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_throwExceptionIfParseJsonFailed branch June 26, 2025 02:23
eco8848 pushed a commit to eco8848/dolphinscheduler that referenced this pull request Aug 8, 2025
davidzollo pushed a commit to davidzollo/dolphinscheduler that referenced this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend improvement make more easy to user or prompt friendly test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement] Throw exception if JSONUtils deserialize json failed

3 participants