Skip to content

Conversation

@ruanwenjun
Copy link
Member

Purpose of the pull request

close #17184

Brief change log

  • Fix varpool will not be assembly into task params.
  • Fix worker will not send varpool to master.
  • Remove unused class.

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contains incompatible change, you should also add it to docs/docs/en/guide/upgrade/incompatible.md

@ruanwenjun ruanwenjun added this to the 3.3.1 milestone May 20, 2025
@ruanwenjun ruanwenjun self-assigned this May 20, 2025
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_removeUnusedParams branch from 5e487a2 to 24bf30f Compare May 21, 2025 14:06
@ruanwenjun ruanwenjun added the bug Something isn't working label May 21, 2025
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_removeUnusedParams branch 2 times, most recently from 9aecc3b to fe1c44e Compare May 21, 2025 16:14
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_removeUnusedParams branch 3 times, most recently from 95a8cfb to 85faec4 Compare May 22, 2025 15:41
@ruanwenjun
Copy link
Member Author

Wait #17203 to fix the IT case.

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_removeUnusedParams branch 13 times, most recently from 5434835 to 3df5065 Compare May 30, 2025 08:58
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_removeUnusedParams branch 3 times, most recently from bf2fa94 to 85bed93 Compare May 30, 2025 14:08
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_removeUnusedParams branch from 85bed93 to 68ddfa3 Compare May 31, 2025 13:51
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍🏻

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 3, 2025

Please retry analysis of this Pull-Request directly on SonarQube Cloud

@ruanwenjun ruanwenjun merged commit 6f12d1d into apache:dev Jun 3, 2025
69 of 70 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_removeUnusedParams branch June 3, 2025 14:18
hackergin pushed a commit to hackergin/dolphinscheduler that referenced this pull request Jun 15, 2025
davidzollo pushed a commit to davidzollo/dolphinscheduler that referenced this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [Task] Task Params can not passed

3 participants