Skip to content

Conversation

@gaoyan1998
Copy link
Contributor

@gaoyan1998 gaoyan1998 commented May 13, 2025

Fix #17175


    private CosStorageProperties getCosStorageProperties() {
       // Here we get the configuration based on the TENCENT_CLOUD_COS_PROPERTY_PREFIX prefix, but the RESOURCE_UPLOAD_PATH below is not this prefix, which causes the basic path configuration to fail to take effect, and it is always /dolphinscheduler
        Map<String, String> cosPropertiesMap =
                PropertyUtils.getByPrefix(CosStorageConstants.TENCENT_CLOUD_COS_PROPERTY_PREFIX);

        return CosStorageProperties.builder()
                .region(cosPropertiesMap.get(CosStorageConstants.TENCENT_CLOUD_COS_REGION))
                .accessKeyId(cosPropertiesMap.get(CosStorageConstants.TENCENT_CLOUD_ACCESS_KEY_ID))
                .accessKeySecret(cosPropertiesMap.get(CosStorageConstants.TENCENT_CLOUD_ACCESS_KEY_SECRET))
                .bucketName(cosPropertiesMap.get(CosStorageConstants.TENCENT_CLOUD_COS_BUCKET_NAME))
                .resourceUploadPath(
                        cosPropertiesMap.getOrDefault(StorageConstants.RESOURCE_UPLOAD_PATH,
                                CosStorageConstants.DEFAULT_COS_RESOURCE_UPLOAD_PATH))
                .build();
    }

@gaoyan1998 gaoyan1998 changed the title [Fix-#17175]The issue that the base path of COS resources is obtained is incorrect [Fix-#17175]The base path of COS resources obtained is incorrect May 13, 2025
@SbloodyS SbloodyS changed the title [Fix-#17175]The base path of COS resources obtained is incorrect [Fix-17175]The base path of COS resources obtained is incorrect May 13, 2025
@SbloodyS SbloodyS changed the title [Fix-17175]The base path of COS resources obtained is incorrect [Fix-17175] The base path of COS resources obtained is incorrect May 13, 2025
@SbloodyS SbloodyS added this to the 3.3.1 milestone May 13, 2025
@SbloodyS SbloodyS added the bug Something isn't working label May 13, 2025
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

And we can use resource.tencent.cloud.resource.storage.upload.base.path to hot fix this.

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sonarqubecloud
Copy link

@ruanwenjun ruanwenjun merged commit a41e34f into apache:dev May 16, 2025
70 checks passed
davidzollo pushed a commit to davidzollo/dolphinscheduler that referenced this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend bug Something isn't working priority:middle

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [API] COS Resource Get resourceUploadPath is incorrect

3 participants