[Fix-17173] [JVM Metrics] Fix JVM memory monitoring metrics #17174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dill21yu
requested review from
EricGao888,
Gallardot,
SbloodyS,
caishunfeng and
ruanwenjun
as code owners
|
Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md) |
dill21yu
changed the title
…theses to make the operator precedence explicit
SbloodyS
added
bug
SbloodyS
reviewed
May 13, 2025
...er-meter/src/main/java/org/apache/dolphinscheduler/meter/metrics/DefaultMetricsProvider.java
Show resolved
Hide resolved
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
Contributor
Author
|
Please help review the code @ruanwenjun @Gallardot @EricGao888 @caishunfeng |
|
Awesome work, congrats on your first merged pull request! |
davidzollo
pushed a commit
to davidzollo/dolphinscheduler
that referenced
this pull request
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
close #17173
Brief change log
In the BaseHeartBeat model, add fields for JVM heap memory and non-heap memory usage and maximum values. Modify MasterHeartBeatTask and WorkerHeartBeatTask to collect and report these metrics. Update DefaultMetricsProvider to accurately calculate and provide JVM heap and non-heap memory usage and maximum values. Add corresponding fields in SystemMetrics to store these metrics.
Verify this pull request
This pull request is already covered by existing tests, such as MasterServerLoadProtectionTest、WorkerServerLoadProtectionTest.
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md