Skip to content

Conversation

@SbloodyS
Copy link
Member

Purpose of the pull request

Hotfix ci error in https://github.com/apache/dolphinscheduler/actions/runs/14956073201/job/42011902487?pr=17160

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contains incompatible change, you should also add it to docs/docs/en/guide/upgrade/incompatible.md

@github-actions github-actions bot added the CI&CD label May 12, 2025
@SbloodyS SbloodyS added this to the 3.3.1 milestone May 12, 2025
@SbloodyS SbloodyS added the chore label May 12, 2025
@ruanwenjun
Copy link
Member

ruanwenjun commented May 12, 2025

for file in $(locate "$PWD*/*.md" | grep -v ./deploy/terraform/aws/README.md | grep -v ./.github); do
    markdown-link-check -c .dlc.json -q "$file" &
done

It seems hard to find out which file exist dead link, and which file cost long time, since we use async here?

@SbloodyS
Copy link
Member Author

for file in $(locate "$PWD*/*.md" | grep -v ./deploy/terraform/aws/README.md | grep -v ./.github); do
    markdown-link-check -c .dlc.json -q "$file" &
done

It seems hard to find out which file exist dead link, and which file cost long time, since we use async here?

Yes. But it seems that because the number of our files has increased rapidly, CI's servers are running very slowly.

@SbloodyS
Copy link
Member Author

PATL @ruanwenjun @Gallardot

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

@SbloodyS SbloodyS merged commit 87f6b2f into apache:dev May 12, 2025
71 checks passed
@SbloodyS SbloodyS deleted the hotfix_ci_error branch May 12, 2025 10:06
davidzollo pushed a commit to davidzollo/dolphinscheduler that referenced this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants