[Improvement-16767] Takeover sub-workflow in sub-workflow-task #17153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reele
requested review from
SbloodyS,
caishunfeng and
ruanwenjun
as code owners
ruanwenjun
reviewed
Apr 29, 2025
...heduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/WorkflowInstanceMapper.java
Show resolved
Hide resolved
...o/src/main/java/org/apache/dolphinscheduler/dao/repository/impl/WorkflowInstanceDaoImpl.java
Show resolved
Hide resolved
...heduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/WorkflowInstanceMapper.java
Show resolved
Hide resolved
...ler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/WorkflowInstanceMapper.xml
Show resolved
Hide resolved
ruanwenjun
changed the title
ruanwenjun
added
improvement
ruanwenjun
previously approved these changes
Apr 29, 2025
Member
ruanwenjun
left a comment
ruanwenjun
left a comment
There was a problem hiding this comment.
LGTM, I will improve the BaseDao to reduce the method number.
ruanwenjun
reviewed
Apr 29, 2025
Comment on lines
57
to
58
| private List<WorkflowInstanceRelation> workflowInstanceRelations; | ||
|
|
Member
There was a problem hiding this comment.
Is this used? please initialized.
ruanwenjun
reviewed
Apr 30, 2025
...va/org/apache/dolphinscheduler/server/master/integration/WorkflowTestCaseContextFactory.java
Outdated
Show resolved
Hide resolved
|
Closed
3 tasks
davidzollo
pushed a commit
to davidzollo/dolphinscheduler
that referenced
this pull request
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
close #16767
Brief change log
Verify this pull request
This change added tests and can be verified as follows:
Added take-over sub-workflow in WorkflowInstanceFailoverTestCase.
@ruanwenjun