[Fix-17142] Add UK uniq_workflow_definition_code on t_ds_workflow_definition #17151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanwenjun
force-pushed
the
dev_wenjun_removeChannelLock
branch
from
6c16f48 to
c86eea1
Compare
ruanwenjun
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the workflow definition table schema by introducing a unique constraint on the code column and adjusting primary key definitions to ensure uniqueness. The key changes include:
- Adding a unique index (uniq_workflow_definition_code) on the code column in PostgreSQL, MySQL, and H2.
- Dropping the code component from the composite primary key in MySQL.
- Updating index creation statements to align with the new unique constraint.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| dolphinscheduler-dao/src/main/resources/sql/upgrade/3.3.1_schema/postgresql/dolphinscheduler_dml.sql | Added license header only. |
| dolphinscheduler-dao/src/main/resources/sql/upgrade/3.3.1_schema/postgresql/dolphinscheduler_ddl.sql | Added drop and create unique index statements for PostgreSQL. |
| dolphinscheduler-dao/src/main/resources/sql/upgrade/3.3.1_schema/mysql/dolphinscheduler_dml.sql | Added license header only. |
| dolphinscheduler-dao/src/main/resources/sql/upgrade/3.3.1_schema/mysql/dolphinscheduler_ddl.sql | Dropped composite primary key and added unique key constraint in MySQL. |
| dolphinscheduler-dao/src/main/resources/sql/dolphinscheduler_postgresql.sql | Replaced non-unique index with a unique index in PostgreSQL schema. |
| dolphinscheduler-dao/src/main/resources/sql/dolphinscheduler_mysql.sql | Updated the primary key and added the unique index in MySQL schema. |
| dolphinscheduler-dao/src/main/resources/sql/dolphinscheduler_h2.sql | Renamed the unique key for consistency in H2 schema. |
Comments suppressed due to low confidence (2)
dolphinscheduler-dao/src/main/resources/sql/upgrade/3.3.1_schema/mysql/dolphinscheduler_ddl.sql:18
- Dropping the composite primary key that includes 'code' is a significant schema change. Please verify that this alteration does not negatively impact database relationships or query performance, especially if any foreign keys or logic rely on the unique combination of (id, code).
ALTER TABLE t_ds_workflow_definition DROP PRIMARY KEY;
dolphinscheduler-dao/src/main/resources/sql/dolphinscheduler_mysql.sql:429
- Changing the primary key from a composite key (id, code) to a single-column primary key (id) may affect queries or constraints that depend on the composite key. Please confirm that all dependent application logic and database relationships have been updated accordingly.
PRIMARY KEY (`id`),
c86eea1 to
ddd1d52
Compare
Gallardot
approved these changes
May 11, 2025
ruanwenjun
force-pushed
the
dev_wenjun_removeChannelLock
branch
from
ddd1d52 to
af9bcda
Compare
|
davidzollo
pushed a commit
to davidzollo/dolphinscheduler
that referenced
this pull request
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
close #17142
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md