[Fix-17109] Recovered workflow host may incorrect #17112
Conversation
.../org/apache/dolphinscheduler/api/executor/workflow/StopWorkflowInstanceExecutorDelegate.java
Outdated
Show resolved
Hide resolved
| } catch (ServiceException e) { | ||
| throw e; | ||
| } catch (Exception e) { | ||
| log.error("WorkflowInstance stop failed, workflowInstanceId: {}, workflowInstanceName: {}", workflowInstance.getId(), workflowInstance.getName(), e); |
There was a problem hiding this comment.
Can we remove this log? Since the exception stack will be logged by aspect.
There was a problem hiding this comment.
the following ServiceException didn't contain the original call stack, it won't print to api log, so i added this.
There was a problem hiding this comment.
it's not a good way, i'll remove it first.
There was a problem hiding this comment.
Ok, I got you, since ServiceException are seems as expected exception, although it contains the origin stack, but will not log, so we need to change the aspect code to log the exception stack.
|
Please fix the code style. |
fixed |
…/api/executor/workflow/StopWorkflowInstanceExecutorDelegate.java Co-authored-by: xiangzihao <[email protected]>
ruanwenjun
force-pushed
the
fix-recovered-workflow-host-may-incorrect
branch
from
78ff9ac to
7fca832
Compare
|
4 participants
fix #17109
Brief change log
add
sethostinRecoverFailureTaskCommandHandlerandWorkflowFailoverCommandHandlerVerify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md