Skip to content

Conversation

@Oscarcheng0312
Copy link
Contributor

@Oscarcheng0312 Oscarcheng0312 commented Mar 28, 2025

Purpose of the pull request

Improve the architecture documentation by adding JDBC and Etcd support information for event monitoring and distributed lock.

close #16755

Brief change log

  • Update docs/docs/en/architecture/design.md
  • Describe newly supported JDBC and Etcd implementations alongside ZooKeeper

Verify this pull request

This is a documentation-only change and does not require test verification.

@Oscarcheng0312
Copy link
Contributor Author

With the correct changes, this PR improves the architecture documentation by reflecting newly supported JDBC and Etcd implementations. Please help review when convenient. Sorry again for my mistake.

@SbloodyS SbloodyS added the first time contributor First-time contributor label Mar 28, 2025
@Oscarcheng0312 Oscarcheng0312 requested a review from SbloodyS March 30, 2025 04:59
@SbloodyS SbloodyS requested a review from ruanwenjun June 11, 2025 03:26
ruanwenjun
ruanwenjun previously approved these changes Jun 12, 2025
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SbloodyS
SbloodyS previously approved these changes Jun 13, 2025
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@SbloodyS SbloodyS added this to the 3.3.1 milestone Jun 13, 2025
@SbloodyS SbloodyS added the improvement make more easy to user or prompt friendly label Jun 13, 2025
@SbloodyS
Copy link
Member

Please run mvn spotless:apply to format code @Oscarcheng0312

@Oscarcheng0312
Copy link
Contributor Author

Please run mvn spotless:apply to format code @Oscarcheng0312

OK

@Oscarcheng0312 Oscarcheng0312 dismissed stale reviews from SbloodyS and ruanwenjun via 24793d7 June 13, 2025 08:58
@Oscarcheng0312 Oscarcheng0312 force-pushed the improve-design-doc branch 2 times, most recently from 24793d7 to 774646e Compare June 13, 2025 09:02
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun merged commit 09d15a0 into apache:dev Jun 16, 2025
33 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 16, 2025

Awesome work, congrats on your first merged pull request!

@Oscarcheng0312 Oscarcheng0312 deleted the improve-design-doc branch June 16, 2025 07:50
davidzollo pushed a commit to davidzollo/dolphinscheduler that referenced this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

document first time contributor First-time contributor improvement make more easy to user or prompt friendly ready-to-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Doc][architecture] Event monitoring and distributed locks implementation

4 participants